Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose TransactionPool transaction timeout settings #998

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Conversation

AionJayT
Copy link
Collaborator

@AionJayT AionJayT commented Oct 1, 2019

Notice

Please submit your PR to the master branch and rebase your code on master before opening the pull request.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

@@ -78,6 +89,11 @@ public String toXML() {
xmlWriter.writeCharacters(String.valueOf(this.getCacheMax()));
xmlWriter.writeEndElement();

xmlWriter.writeCharacters("\r\n\t\t");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add config comment in the toXML

@AionJayT AionJayT force-pushed the AKI-367 branch 2 times, most recently from a801c3f to 4236c21 Compare October 1, 2019 20:26
@AionJayT AionJayT merged commit 9c4ca7f into master Oct 2, 2019
@AionJayT AionJayT deleted the AKI-367 branch October 2, 2019 16:41
@AionJayT AionJayT added this to the 0.4.2 milestone Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant