Add terminology for Declarative clients #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR feedback, clarifications Rework AIP 129, add accepted normalizations Semantic string --> field values Add naming section for effective values Remove 129
|
There are a few other instances of |
toumorokoshi
suggested changes
Jul 24, 2023
aip/general/0009.md
Outdated
| @@ -147,7 +151,16 @@ An API that operates across a network of computers. Network APIs communicate | |||
| using network protocols including HTTP, and are frequently produced by | |||
| organizations separate from those that consume them. | |||
|
|
|||
| [IaC]: #iac | |||
| ### Single Owner Fields | |||
There was a problem hiding this comment.
I don't think single-owner fields should be a glossary term. See https://github.com/aip-dev/google.aip.dev/pull/1144/files#r1272461411.
at minimum the guidance needs to be moved to an AIP that's not the glossary.
There was a problem hiding this comment.
Removed from this PR, will add back to the 129 PR
slevenick
force-pushed
the
defaults-aip-terms
branch
from
a7399a0
to
3eaf3d8
Compare
toumorokoshi
approved these changes
Aug 2, 2023
bgrant0607
reviewed
Aug 2, 2023
slevenick
force-pushed
the
defaults-aip-terms
branch
from
0a90573
to
3eaf3d8
Compare
toumorokoshi
changed the title
Hkoma95
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add terms for upcoming AIP 129
This is split from #1144 to make review easier