Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AIP-192): Expand deprecated comment requirement to all components #1198

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 11, 2023

Expand deprecation comment requirement to all proto file elements. This documentation is crucial to consumers needing to migrate off of the element.

@parthea parthea requested a review from a team as a code owner August 11, 2023 21:04
@parthea parthea changed the title fix(AIP-192): Clarify deprecation requirements for messages fix(AIP-192): Clarify deprecation requirements for components Aug 11, 2023
@noahdietz noahdietz requested review from noahdietz and removed request for hrasadi August 11, 2023 21:06
aip/general/0192.md Outdated Show resolved Hide resolved
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
@parthea parthea changed the title fix(AIP-192): Clarify deprecation requirements for components fix(AIP-192): Expand deprecated comment requirement to all components Aug 11, 2023
@noahdietz noahdietz requested review from andrei-scripniciuc and removed request for toumorokoshi August 14, 2023 20:19
@noahdietz noahdietz merged commit 6662f83 into aip-dev:master Aug 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants