Windows no longer works

[jaxbot]

The new diff.vim seems to have a conflict issue on Vim for Windows; it's unable to read the temp file correctly. I don't know what your feelings are towards supporting/not supporting Windows, but it used to work until the recent refactorings, so I thought I'd chime in and point that out.

I have it forked on my Win8 machine right now and have been playing with it, so if I get time later today, I'll see about fixing it and issuing a PR

[airblade]

Thanks for letting me know. I do want to support Windows.

There's an outstanding issue concerning escaping filenames on Windows (#104) – but this must be different if it was working for you until the recent refactoring.

Here's what I'd look at:

• Is the problem with the realtime diff, the non-realtime diff (i.e. disk-based diff), or both?
• If you echo the system command being run in diff.vim, and then try to run it manually from the command line, what happens?

I'd be very grateful if you could investigate this because I don't have easy access to a Windows box.

[jaxbot]

I have realtime disabled, so an issue exists there, at the very least. I believe the issue is escaping/running the command correctly on a Windows command line vs. a "true" shell. I like some of the new features you've put in here, and the fix should be fairly straightforward, so I'll look into it later today and get back to you.

Thanks!

[airblade]

I'm sure the problem is to do with escaping for Windows. This is the one part of vim-gitgutter which I've always felt uncomfortable with – so any help would be much appreciated.

[jaxbot]

The pull request above fixes the issue with GitGutter, but now GitGutter throws a fit when I run Gstatus from Fugitive, something about being unable to load a temporary file. Any ideas?

[jaxbot]

Re: the issue with Fugitive, the problem appears to be that git is returning an error code when it sees that .git/index is not being tracked, which causes the system() call to write a file. On Windows, Vim executes commands with system() by writing the output to a temp file, then reading that in, if I remember correctly. A way around this is to wrap the entire cmd statement in (( cmd ) || true), but this seems really quirky.

Does the Fugitive issue exist on Linux/OSX as well, or is this a Windows thing?

[airblade]

Is the Fugitive problem fixed for you now?

(BTW I just pushed a few updates.)

[jaxbot]

No, unfortunately; everything except Fugitive is fixed, though. I think the git command is failing because .git/index is not tracked, obviously, so the first command evaluates to false. If I OR the entire cmd with true, Fugitive works

[airblade]

vim-gitgutter is supposed to handle files which aren't tracked by git. It does this:

cd /path/to/dir && git ls-files --error-unmatch && (git diff ... | grep ... || true)

If a file isn't tracked by git, e.g. .git/index, the git ls-files command will exit with a non-zero status code and the plugin will raise the diff failed error – which is caught in GitGutter() and handled.

I'm not sure why it's not working for you. Can you give me steps to reproduce (I don't use Fugitive so I'm not sure what to invoke).

[jaxbot]

Yeah, I noticed that. I think the problem is that gVim Win32 does not generate an output file when the exit code is not 0, so the system call fails. It's a weird Windows fluke

[jaxbot]

Steps to reproduce: open Gstatus, or Gcommit, or any of the preview windows. GitGutter fails, complaining about a random temp file (which is used to pipe system calls on Windows. I don't know why, either)

[airblade]

If you edit .git/index directly, without using Fugitive, can you reproduce the problem?

[airblade]

I installed Fugitive (I'm on OS X / bash) and :Gstatus works fine for me.

[jaxbot]

Right, I'm 99% sure the issue is with Vim for Windows' hacky way of piping system() into a temporary file and reading the output.

And yes, if I :e .git/index, I get the same error

[airblade]

I think Vim does the same piping on Unix: see &shelltemp. BTW, please could you post a screenshot of the error?

So to clarify, you get this error whenever you edit a non-git-tracked file in a git repo?

I've spent the entire day looking at Windows escaping. It's awful: different versions of Windows and shells behave differently, and the way Vim shells out changes from one patch to the next. I've been looking at how vundle, vim-dispatch and vim-signify do it...and of course each one has a different solution ;)