-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate from travis to github actions #117
Conversation
Co-authored-by: Paul Mineev <pmineev@blend.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
9e83f37
to
d4e869b
Compare
d4e869b
to
9985fc7
Compare
9985fc7
to
83a2e8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more thing - to "cap off" the matrix, you need a single "echo done!" job that needs: [test]
, so that single job can be the Required Branch Protection thing.
73625d0
to
faa6a0e
Compare
faa6a0e
to
457920d
Compare
Rebased; this is now good to go. No need for further changes until an admin is able to fix the protected branch settings, at which point i'll merge this :-) |
457920d
to
63611b5
Compare
I’ve already done so; all we can do now is wait. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@ljharb I've added some of the new checks as required in the branch restriction settings, but I seem to be missing a node one that we've done elsewhere. Do you happen to know what I should be searching for here? Is it posttest? |
@lencioni there should be |
The node ones are not showing up. I had done #119 in hopes that it would trigger it, but it seems to not have. In any case, I added posttest now. |
ah, try "latest majors" |
hm, you're right. i'll make a PR to fix it. |
Thanks! I added that one to the settings now, so I think we can call this a wrap |
@lencioni one more thing :-) can we remove the review requirement? i need to be able to push things without a PR to release properly. |
@ljharb agreed, that is super annoying for releasing. I think I've updated the settings now. |
Thanks! The only thing left is that the automatic rebase and allow edits checks only run on a PR :-/ so either we can make those optional, or, add me to the airbnb org with a custom role that allows me to bypass branch protections (which i assume is a bit more difficult, bureaucratically) |
I have made those optional now too. I think that's fine since making them required is unlikely to matter all that much anyway. |
Much obliged, and I agree. |
Implements CI jobs with Github Actions
Passed actions on my fork