Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from travis to github actions #117

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

akellbl4
Copy link

@akellbl4 akellbl4 commented Sep 14, 2022

Implements CI jobs with Github Actions
Passed actions on my fork

Co-authored-by: Paul Mineev <pmineev@blend.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@akellbl4 akellbl4 force-pushed the migrate-to-github-actions branch 2 times, most recently from 9e83f37 to d4e869b Compare September 14, 2022 02:54
@akellbl4 akellbl4 force-pushed the migrate-to-github-actions branch from d4e869b to 9985fc7 Compare September 14, 2022 02:57
@ljharb
Copy link
Collaborator

ljharb commented Sep 14, 2022

@akellbl4 the only other thing this needs is the "restricted branches" setting changed to no longer require travis, which requires an @airbnb employee to change.

Once this lands, the actions will run, after which the restricted branch settings can add the actions it should thenceforth require.

@akellbl4 akellbl4 force-pushed the migrate-to-github-actions branch from 9985fc7 to 83a2e8a Compare September 14, 2022 03:00
@akellbl4 akellbl4 requested a review from ljharb September 14, 2022 03:02
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more thing - to "cap off" the matrix, you need a single "echo done!" job that needs: [test], so that single job can be the Required Branch Protection thing.

@akellbl4 akellbl4 force-pushed the migrate-to-github-actions branch from 73625d0 to faa6a0e Compare September 14, 2022 03:09
@ljharb ljharb force-pushed the migrate-to-github-actions branch from faa6a0e to 457920d Compare September 14, 2022 04:06
@ljharb
Copy link
Collaborator

ljharb commented Sep 14, 2022

Rebased; this is now good to go. No need for further changes until an admin is able to fix the protected branch settings, at which point i'll merge this :-)

@ljharb ljharb force-pushed the migrate-to-github-actions branch from 457920d to 63611b5 Compare September 14, 2022 04:08
@akellbl4
Copy link
Author

Hey @ljharb, how can we ping anyone from @airbnb to take a look on it? :)

@ljharb
Copy link
Collaborator

ljharb commented Sep 16, 2022

I’ve already done so; all we can do now is wait.

Copy link
Contributor

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lencioni lencioni merged commit b594a3a into airbnb:master Feb 16, 2023
@lencioni
Copy link
Contributor

lencioni commented Feb 16, 2023

@ljharb I've added some of the new checks as required in the branch restriction settings, but I seem to be missing a node one that we've done elsewhere.

image

Do you happen to know what I should be searching for here? Is it posttest?

@ljharb
Copy link
Collaborator

ljharb commented Feb 16, 2023

@lencioni there should be posttest, as well as two node ones, but they won't show up in the autocomplete unless they've run recently, and this PR ran months ago :-) the merge into master, however, will populate the dropdown soon so you can add them.

@lencioni
Copy link
Contributor

The node ones are not showing up. I had done #119 in hopes that it would trigger it, but it seems to not have. In any case, I added posttest now.

@ljharb
Copy link
Collaborator

ljharb commented Feb 16, 2023

ah, try "latest majors"

@lencioni
Copy link
Contributor

That gives me a check for each version, unfortunately
image

@ljharb
Copy link
Collaborator

ljharb commented Feb 17, 2023

hm, you're right. i'll make a PR to fix it.

@ljharb
Copy link
Collaborator

ljharb commented Feb 17, 2023

#120

@lencioni
Copy link
Contributor

Thanks! I added that one to the settings now, so I think we can call this a wrap

@ljharb
Copy link
Collaborator

ljharb commented Feb 18, 2023

@lencioni one more thing :-) can we remove the review requirement? i need to be able to push things without a PR to release properly.

@lencioni
Copy link
Contributor

@ljharb agreed, that is super annoying for releasing. I think I've updated the settings now.

@ljharb
Copy link
Collaborator

ljharb commented Feb 21, 2023

Thanks! The only thing left is that the automatic rebase and allow edits checks only run on a PR :-/ so either we can make those optional, or, add me to the airbnb org with a custom role that allows me to bypass branch protections (which i assume is a bit more difficult, bureaucratically)

@lencioni
Copy link
Contributor

I have made those optional now too. I think that's fine since making them required is unlikely to matter all that much anyway.

@ljharb
Copy link
Collaborator

ljharb commented Feb 21, 2023

Much obliged, and I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants