Wrong documentation link in react rules

[DavidHenri008]

In eslint-config-airbnb react rules, many configuration refer to a wrong documentation path.

// Enforce defaultProps declarations alphabetical sorting
// https://github.com/yannickcr/eslint-plugin-react/blob/843d71a432baf0f01f598d7cf1eea75ad6896e4b/docs/rules/jsx-sort-default-props.md
'react/jsx-sort-default-props': ['off', {
   ignoreCase: true,
}],

It should probably not contain the blob ID key but rather the ID master, like:

// Enforce defaultProps declarations alphabetical sorting
// https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-sort-default-props.md
'react/jsx-sort-default-props': ['off', {
   ignoreCase: true,
}],

[ljharb]

It’s not wrong, that’s the sha - which will never change, whereas it could change in master if the rule is renamed or deleted. Have you tried to visit the links?

[DavidHenri008]

It does work but VSCode complains it cannot find the documentation concerning some rules using this sha so I assumed the link was not properly written.

[ljharb]

That’s not about links in a JavaScript comment, which can’t have any runtime behavior; that means you need to run npm install (or you don’t have the right peer deps of the airbnb config installed)

[DavidHenri008]

Unfortunately, the yarn install was fine and my dependencies are all set.

Are you saying it is not related with this plugin?

[ljharb]

You may need to restart vscode.

[DavidHenri008]

Wonderfull it works. Thanks for your advice. I think I am too much used to instant updates, I am always hoping things should work without restarting software or PC...