Skip to content

Add section about Short Circuit Evaluation #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vitorlopez
Copy link

Add section about Short Circuit Evaluation

README.md Outdated
return someFunction();
}
return 'defaultValue';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot a closing triple backtick.

@hshoff
Copy link
Member

hshoff commented Feb 27, 2015

Once @goatslacker's comments are addressed, this LGTM.

@ljharb
Copy link
Collaborator

ljharb commented Dec 23, 2015

@vlopez5 this is great - abusing value selection operators for control flow is bad news bears indeed. Are you still interested in landing this? It'd be great if you could rebase on latest master and address the comments in the PR :-)

@schinsue
Copy link

Please merge this in! :(

@ljharb
Copy link
Collaborator

ljharb commented Apr 24, 2018

@schinsue it's waiting on #188 (comment) and/or the original PR author checking the "allow edits" box on the right side of the PR.

@schinsue
Copy link

schinsue commented Apr 24, 2018

@ljharb Am I allowed to create a fork and follow up on the comments made in the original PR?

EDIT: Maybe this can be closed, as chapter 17.2 Also addresses this.

@vitorlopez
Copy link
Author

I'm sorry for the delay guys... I already checked the box to allow edits! Thanks guys!

@ljharb
Copy link
Collaborator

ljharb commented Apr 24, 2018

I've rebased this; but indeed, https://github.com/airbnb/javascript#control-statements--value-selection seems to already cover it (#1729)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants