-
Notifications
You must be signed in to change notification settings - Fork 26.8k
Add section about Short Circuit Evaluation #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
README.md
Outdated
return someFunction(); | ||
} | ||
return 'defaultValue'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot a closing triple backtick.
Once @goatslacker's comments are addressed, this LGTM. |
@vlopez5 this is great - abusing value selection operators for control flow is bad news bears indeed. Are you still interested in landing this? It'd be great if you could rebase on latest master and address the comments in the PR :-) |
Please merge this in! :( |
@schinsue it's waiting on #188 (comment) and/or the original PR author checking the "allow edits" box on the right side of the PR. |
@ljharb Am I allowed to create a fork and follow up on the comments made in the original PR? EDIT: Maybe this can be closed, as chapter 17.2 Also addresses this. |
I'm sorry for the delay guys... I already checked the box to allow edits! Thanks guys! |
I've rebased this; but indeed, https://github.com/airbnb/javascript#control-statements--value-selection seems to already cover it (#1729) |
Add section about Short Circuit Evaluation