new(xychart): handle rendering + tweening missing values #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
commented
Oct 28, 2020
|
|
||
| const xValues = registryEntries.reduce<XScaleInput[]>( | ||
| (combined, entry) => | ||
| entry ? combined.concat(entry.data.map((d: Datum) => entry.xAccessor(d))) : combined, | ||
| entry | ||
| ? combined.concat(entry.data.map((d: Datum) => entry.xAccessor(d)).filter(valueIsDefined)) |
There was a problem hiding this comment.
verified that d3Extent handles this so no need to filter, will remove
Pull Request Test Coverage Report for Build 334347503
💛 - Coveralls |
| to: { t: 1 }, | ||
| reset: true, | ||
| }); | ||
| const tweened = useSpring({ stroke, fill }); |
There was a problem hiding this comment.
TIL tweened because
Inbetweening or tweening is a key process in all types of animation, including computer animation.
| @@ -132,8 +126,8 @@ export default function BaseBarGroup< | |||
| const bars = registryEntries.flatMap(({ xAccessor, yAccessor, data, key }) => { | |||
| const getLength = (d: Datum) => | |||
| horizontal | |||
| ? (xScale(xAccessor(d)) ?? 0) - xZeroPosition | |||
| : (yScale(yAccessor(d)) ?? 0) - yZeroPosition; | |||
| ? (xScale(xAccessor(d)) ?? NaN) - xZeroPosition | |||
hshoff
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
🐛 Bug Fix
🏠 Internal
This PR is a mix of improvements + new functionality for
xychartwhich are all related by the rabbit hole 🐰 ⚫ I went down trying to fix one problem:The improvements are:
*Seriesand in scale domain calculation/xychartdemoAnimatedPathto handle missing values and a changing number of values by usingd3-interpolate-pathfor interpolatingpathdattributesAreashapes with missing data (see below) but I think it's the best optionreact-springdoes this beautifully except when the # of points changes which is the cause of the above error 😭react-spring@9.0.0-rc.3to see if it did ... but it does notd3-interpolatedoes not handle path string interpolation well (well documented see e.g., here)flubberis the best at handling all edge cases, but it assumes closed polygon shapes (doesn't apply for lines) and its bundle size is 10x whatd3-interpolate-paths is.props.horizontalfrom all*Seriestypes toDataProviderscontext.horizontal(the start of the 🐰 ⚫ )horizontaldetermines orientation forBar-type series, and it controls nearestdatumlogic for mouse events across all*Seriesdevs, most of the timehorizontalcan be inferred fromscaletypes and this could be done once in context vs specified / computed in each*SeriesNote issue with missing area data
@kristw @techniq