feat: styling updates #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girarda
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes in tandem with https://github.com/airbytehq/airbyte-platform-internal/pull/16048 while working towards https://www.figma.com/design/eJAkpEqi2SdKnzZJXjG9HO/Embedded-widget?node-id=0-1&p=f&t=aBtroLNNlxMVgr84-0
Namely: removes a bunch of the styling and pulls it into the webapp so we retain stronger design control. The only piece that remains outside the webapp is the overlay and the empty dialog itself. The "Close" button inside the dialog has been moved. And a handful of other redundant styles as well.
(This is the version of the widget I was using when demoing the above Platform PR)
Does not implement the branding featured in the designs in the overlay yet.