fix: Ensure page token 0 is being passed

[maxi297]

What

Following a couple of tickets, it seems like the injection on the first page stopped working. Here are some of the tickets:

• [source-custom] OffetIncrement is not sent on first request even when inject_on_first_request is set to true airbyte#51505
• [source-declarative-manifest] version > 5.7.5 - airbyte chart versions > 1.1.0 - PageIncrement Pagination no PageNumber in the query parameters during sync airbyte#53140

How

This was caused by the first token being 0 which gets evaluated as False and therefore is not injected. We now validate None explicitly instead

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of pagination tokens to correctly support cases where the initial token is zero.
• Tests
  • Added a test to ensure pagination works properly when the initial token is zero.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the initialization logic for the next_page_token variable in the SimpleRetriever class to ensure that a zero value is correctly recognized as a valid initial token. Additionally, a new unit test is introduced to verify that when the paginator's initial token is zero, it is properly passed through the retrieval process. No changes are made to public APIs or exported entity signatures.

Changes

File(s)	Change Summary
airbyte_cdk/sources/declarative/retrievers/simple_retriever.py	Refined the initialization of next_page_token to distinguish between None and falsy values.
unit_tests/sources/declarative/retrievers/test_simple_retriever.py	Added a unit test to ensure zero is handled as a valid initial token in pagination logic.

Sequence Diagram(s)

sequenceDiagram
    participant Test as Unit Test
    participant Retriever as SimpleRetriever
    participant Paginator as Paginator
    participant Fetch as _fetch_next_page

    Test->>Paginator: get_initial_token() returns 0
    Test->>Retriever: read_records()
    Retriever->>Fetch: _fetch_next_page(..., next_page_token={"next_page_token": 0})
    Fetch-->>Retriever: Returns mocked HTTP response
    Retriever-->>Test: Yields records (none in this test)

Loading

Would you like to see additional tests for other falsy initial tokens, or is this coverage sufficient for your use case, wdyt?

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efceea2 and 36a1489.

📒 Files selected for processing (2)

• airbyte_cdk/sources/declarative/retrievers/simple_retriever.py (1 hunks)
• unit_tests/sources/declarative/retrievers/test_simple_retriever.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• airbyte_cdk/sources/declarative/retrievers/simple_retriever.py
• unit_tests/sources/declarative/retrievers/test_simple_retriever.py

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: Pytest (All, Python 3.11, Ubuntu)
• GitHub Check: Pytest (All, Python 3.10, Ubuntu)
• GitHub Check: SDM Docker Image Build
• GitHub Check: Pytest (Fast)
• GitHub Check: Analyze (python)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[brianjlai]

🚢

[maxi297]

/autofix

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made,
those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

PR auto-fix job started... Check job output.

✅ Changes applied successfully.