Skip to content

feat: add sorting import option for ruff #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2024
Merged

feat: add sorting import option for ruff #94

merged 2 commits into from
Nov 28, 2024

Conversation

artem1205
Copy link
Contributor

@artem1205 artem1205 commented Nov 28, 2024 •
edited
Loading

What

  • add sorting import option for ruff
[tool.ruff.lint]
select = ["I"]

@artem1205
CDK: add sorting import option
8cd3295 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 self-assigned this Nov 28, 2024
@artem1205
Copy link
Contributor Author

artem1205 commented Nov 28, 2024 •
edited by github-actions bot
Loading

/autofix

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made,
those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

@artem1205 artem1205 marked this pull request as ready for review November 28, 2024 10:31
@artem1205 artem1205 changed the title CDK: add sorting import option fear: add sorting import option for ruff Nov 28, 2024
@artem1205 artem1205 changed the title fear: add sorting import option for ruff feaе: add sorting import option for ruff Nov 28, 2024
@artem1205 artem1205 changed the title feaе: add sorting import option for ruff feat: add sorting import option for ruff Nov 28, 2024
@artem1205 artem1205 merged commit 5f0831e into main Nov 28, 2024
22 of 28 checks passed
@artem1205 artem1205 deleted the artem1205/ruff-sort-imports branch November 28, 2024 10:47
@artem1205 artem1205 mentioned this pull request Nov 28, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bazarnov bazarnov bazarnov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@artem1205 artem1205

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artem1205 @bazarnov