🎉 Google sheets bugfix: handle duplicate sheet headers #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@makalaaneesh thanks for your PR! I will review this very soon, just a little crunched on time yesterday :) |
sherifnada
suggested changes
Apr 18, 2021
There was a problem hiding this comment.
@makalaaneesh looks great! just a few small tweaks but I think we can merge this very soon.
| if duplilcate_headers: | ||
| duplicate_headers_in_sheet[sheet_name] = duplilcate_headers | ||
| except Exception as err: | ||
| logger.error(str(err)) |
There was a problem hiding this comment.
if there is an error we should also return a fail message
| for sheet_name in sheet_names: | ||
| try: | ||
| header_row_data = Helpers.get_first_row(client, spreadsheet_id, sheet_name) | ||
| _, duplilcate_headers = Helpers.get_vaild_headers_and_duplicates(header_row_data) |
There was a problem hiding this comment.
typo: duplilcate should be duplicate
| @@ -63,6 +63,27 @@ def check(self, logger: AirbyteLogger, config: json) -> AirbyteConnectionStatus: | |||
| status=Status.FAILED, message=f"Unable to connect with the provided credentials to spreadsheet. Error: {reason}" | |||
| ) | |||
|
|
|||
| # Check for duplicates | |||
There was a problem hiding this comment.
Suggested change
| # Check for duplicates | |
| # Check for duplicate headers |
| return AirbyteStream(name=sheet_name, json_schema=sheet_json_schema) | ||
|
|
||
| @staticmethod | ||
| def get_vaild_headers_and_duplicates(header_row_values: List[str]) -> (List[str], List[str]): |
| self.assertEqual(expected_stream, actual_stream) | ||
|
|
||
| def test_duplicate_headers_to_ab_stream_fails(self): | ||
| def test_duplicate_headers_retrived(self): |
|
So many typos, my bad! |
|
I wish all PRs had typos as their main issue , I'll say that 😜 |
sherifnada
approved these changes
Apr 20, 2021
sherifnada
changed the title
|
thanks @makalaaneesh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This solves #2153
How
checkfails if there are duplicate headers with a message.discoverignores duplicate headers from the AirbyteStream. It logs a warningPre-merge Checklist
Recommended reading order