make QA checks handle missing dockerfiles #30458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
alafanechere
commented
Sep 15, 2023
Comment on lines
110
to
153
| @pytest.mark.parametrize("with_test_dependencies", [True, False]) | ||
| def test_get_all_gradle_dependencies(with_test_dependencies): | ||
| build_file = Path("airbyte-integrations/connectors/source-postgres-strict-encrypt/build.gradle") | ||
| if with_test_dependencies: | ||
| all_dependencies = utils.get_all_gradle_dependencies(build_file) | ||
| expected_dependencies = [ | ||
| Path("airbyte-cdk/java/airbyte-cdk"), | ||
| Path("airbyte-db/db-lib"), | ||
| Path("airbyte-json-validation"), | ||
| Path("airbyte-config-oss/config-models-oss"), | ||
| Path("airbyte-commons"), | ||
| Path("airbyte-test-utils"), | ||
| Path("airbyte-api"), | ||
| Path("airbyte-connector-test-harnesses/acceptance-test-harness"), | ||
| Path("airbyte-commons-protocol"), | ||
| Path("airbyte-integrations/bases/base-java"), | ||
| Path("airbyte-commons-cli"), | ||
| Path("airbyte-integrations/bases/base"), | ||
| Path("airbyte-integrations/connectors/source-postgres"), | ||
| Path("airbyte-integrations/bases/debezium"), | ||
| Path("airbyte-integrations/connectors/source-jdbc"), | ||
| Path("airbyte-integrations/connectors/source-relational-db"), | ||
| Path("airbyte-integrations/bases/standard-source-test"), | ||
| ] | ||
| assert len(all_dependencies) == len(expected_dependencies) | ||
| assert all([dependency in expected_dependencies for dependency in all_dependencies]) | ||
| else: | ||
| all_dependencies = utils.get_all_gradle_dependencies(build_file, with_test_dependencies=False) | ||
| expected_dependencies = [ | ||
| Path("airbyte-cdk/java/airbyte-cdk"), | ||
| Path("airbyte-db/db-lib"), | ||
| Path("airbyte-json-validation"), | ||
| Path("airbyte-config-oss/config-models-oss"), | ||
| Path("airbyte-commons"), | ||
| Path("airbyte-integrations/bases/base-java"), | ||
| Path("airbyte-commons-cli"), | ||
| Path("airbyte-integrations/bases/base"), | ||
| Path("airbyte-integrations/connectors/source-postgres"), | ||
| Path("airbyte-integrations/bases/debezium"), | ||
| Path("airbyte-integrations/connectors/source-jdbc"), | ||
| Path("airbyte-integrations/connectors/source-relational-db"), | ||
| ] | ||
| assert len(all_dependencies) == len(expected_dependencies) | ||
| assert all([dependency in expected_dependencies for dependency in all_dependencies]) |
There was a problem hiding this comment.
This test is brittle as it's vulnerable to connector specific changes. It does pass anymore as the source-postgres-strict-encrypt connector dependencies changed.
This was referenced Sep 15, 2023
alafanechere
force-pushed
the
09-14-change_our_python_connector_build_process_to_use_the_base_images
branch
from
e5e4d7b
to
2aef971
Compare
This was referenced Sep 15, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Describe what the change is solving
It helps to add screenshots if it affects the frontend.
How
Describe the solution
Recommended reading order
x.javay.python🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest.0.0.1Dockerfilehas version0.0.1README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog with an entry for the initial version. See changelog exampledocs/integrations/README.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:generateScaffoldsthen checking in your changes