source-file/faker: make them use our base image + delete dockerfile #30468

alafanechere · 2023-09-15T10:32:48Z

What

Relates to #30236
Build source-file and source-faker with our base image

How

Set the baseImage metadata
Delete their Dockerfiles

User impact

These connectors will be published once all the stacked PR belows are folded and merged in master.

alafanechere · 2023-09-15T10:33:07Z

Current dependencies on/for this PR:

master
- PR [airbyte-ci] build python connectors from base images #30456

This comment was auto-generated by Graphite.

github-actions · 2023-09-15T10:33:14Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

github-actions · 2023-09-15T11:16:52Z

source-file test report (commit `c8dbe4db79`) - ❌

⏲️ Total pipeline duration: 20mn13s

Step	Result
Connector package install	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-file/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

github-actions · 2023-09-15T15:21:15Z

source-file-secure test report (commit `e3aebbcdf9`) - ❌

⏲️ Total pipeline duration: 01mn39s

Step	Result
Build source-file-secure docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-file-secure/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

github-actions · 2023-09-15T15:22:08Z

source-file test report (commit `e3aebbcdf9`) - ❌

⏲️ Total pipeline duration: 02mn35s

Step	Result
Build source-file docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	❌
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-file/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

github-actions · 2023-09-17T15:21:16Z

source-file-secure test report (commit `41c4907fd3`) - ❌

⏲️ Total pipeline duration: 01mn03s

Step	Result
Build source-file-secure docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-file-secure/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

github-actions · 2023-09-17T15:21:34Z

source-faker test report (commit `41c4907fd3`) - ✅

⏲️ Total pipeline duration: 01mn53s

Step	Result
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

github-actions · 2023-09-17T15:21:39Z

source-file test report (commit `41c4907fd3`) - ❌

⏲️ Total pipeline duration: 02mn00s

Step	Result
Build source-file docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	❌
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-file/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

github-actions · 2023-09-18T10:44:41Z

source-file-secure test report (commit `b406c99444`) - ❌

⏲️ Total pipeline duration: 53.48s

Step	Result
Build source-file-secure docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-file-secure/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

github-actions · 2023-09-18T10:44:59Z

source-faker test report (commit `b406c99444`) - ✅

⏲️ Total pipeline duration: 01mn46s

Step	Result
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

github-actions · 2023-09-18T10:45:06Z

source-file test report (commit `b406c99444`) - ❌

⏲️ Total pipeline duration: 01mn51s

Step	Result
Build source-file docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	❌
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-file/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

github-actions · 2023-09-18T10:47:56Z

source-file-secure test report (commit `6d77106d62`) - ❌

⏲️ Total pipeline duration: 41.86s

Step	Result
Build source-file-secure docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-file-secure/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

github-actions · 2023-09-18T10:48:09Z

source-faker test report (commit `6d77106d62`) - ✅

⏲️ Total pipeline duration: 56.51s

Step	Result
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

github-actions · 2023-09-18T10:48:25Z

source-file test report (commit `6d77106d62`) - ❌

⏲️ Total pipeline duration: 01mn11s

Step	Result
Build source-file docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	❌
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-file/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

github-actions · 2023-09-18T14:23:25Z

source-file-secure test report (commit `a43d54b1e9`) - ❌

⏲️ Total pipeline duration: 53.72s

Step	Result
Build source-file-secure docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-file-secure/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

github-actions · 2023-09-18T14:23:34Z

source-faker test report (commit `a43d54b1e9`) - ✅

⏲️ Total pipeline duration: 01mn38s

Step	Result
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

github-actions · 2023-09-18T14:23:36Z

source-file test report (commit `a43d54b1e9`) - ❌

⏲️ Total pipeline duration: 01mn40s

Step	Result
Build source-file docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	❌
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-file/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 15, 2023

octavia-squidington-iii added connectors/source/file connectors/source/file-secure connectors/source/faker labels Sep 15, 2023

airbytehq deleted a comment from github-actions bot Sep 15, 2023

alafanechere mentioned this pull request Sep 15, 2023

[airbyte-ci] test connectors inside their built container #30474

Merged

alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from fbb9c61 to 001d411 Compare September 15, 2023 14:01

alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from c8dbe4d to 2859334 Compare September 15, 2023 14:01

alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from 001d411 to 43049f0 Compare September 15, 2023 14:12

alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from 2859334 to acc3c29 Compare September 15, 2023 14:12

airbytehq deleted a comment from github-actions bot Sep 15, 2023

alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from 43049f0 to 2690638 Compare September 15, 2023 15:08

alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from acc3c29 to e3aebbc Compare September 15, 2023 15:09

alafanechere mentioned this pull request Sep 17, 2023

[airbyte-ci] introduce an autocommit command to update base image version to the latest one #30508

Closed

alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from 2690638 to 5938a15 Compare September 17, 2023 15:16

alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from e3aebbc to 41c4907 Compare September 17, 2023 15:16

alafanechere mentioned this pull request Sep 18, 2023

[airbyte-ci] Implement pre/post build hooks #30513

Closed

alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from 5938a15 to b83cb4d Compare September 18, 2023 10:40

alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from 41c4907 to b406c99 Compare September 18, 2023 10:40

alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from b83cb4d to 9029852 Compare September 18, 2023 10:45

alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from b406c99 to 6d77106 Compare September 18, 2023 10:45

alafanechere mentioned this pull request Sep 18, 2023

[airbyte-ci] new commands for migration to base image #30520

Merged

alafanechere added 2 commits September 18, 2023 16:15

source-file/faker: make them use our base image + delete dockerfile

920a12e

fix typos

a43d54b

alafanechere mentioned this pull request Sep 18, 2023

[airbyte-ci] implement pre/post build hooks #30526

Merged

alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from 9029852 to e6bcea4 Compare September 18, 2023 14:16

alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from 6d77106 to a43d54b Compare September 18, 2023 14:17

alafanechere closed this Sep 18, 2023

This was referenced Sep 18, 2023

[airbyte-ci]: new check on python certified connector to validate their base image use #30527

Merged

Make certified python connectors use our base image #30528

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

source-file/faker: make them use our base image + delete dockerfile #30468

source-file/faker: make them use our base image + delete dockerfile #30468

alafanechere commented Sep 15, 2023 •

edited

Loading

alafanechere commented Sep 15, 2023 •

edited by bnchrch

Loading

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 17, 2023

github-actions bot commented Sep 17, 2023

github-actions bot commented Sep 17, 2023

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

source-file/faker: make them use our base image + delete dockerfile #30468

source-file/faker: make them use our base image + delete dockerfile #30468

Conversation

alafanechere commented Sep 15, 2023 • edited Loading

What

How

User impact

alafanechere commented Sep 15, 2023 • edited by bnchrch Loading

github-actions bot commented Sep 15, 2023

Before Merging a Connector Pull Request

github-actions bot commented Sep 15, 2023

source-file test report (commit c8dbe4db79) - ❌

github-actions bot commented Sep 15, 2023

source-file-secure test report (commit e3aebbcdf9) - ❌

github-actions bot commented Sep 15, 2023

source-file test report (commit e3aebbcdf9) - ❌

github-actions bot commented Sep 17, 2023

source-file-secure test report (commit 41c4907fd3) - ❌

github-actions bot commented Sep 17, 2023

source-faker test report (commit 41c4907fd3) - ✅

github-actions bot commented Sep 17, 2023

source-file test report (commit 41c4907fd3) - ❌

github-actions bot commented Sep 18, 2023

source-file-secure test report (commit b406c99444) - ❌

github-actions bot commented Sep 18, 2023

source-faker test report (commit b406c99444) - ✅

github-actions bot commented Sep 18, 2023

source-file test report (commit b406c99444) - ❌

github-actions bot commented Sep 18, 2023

source-file-secure test report (commit 6d77106d62) - ❌

github-actions bot commented Sep 18, 2023

source-faker test report (commit 6d77106d62) - ✅

github-actions bot commented Sep 18, 2023

source-file test report (commit 6d77106d62) - ❌

github-actions bot commented Sep 18, 2023

source-file-secure test report (commit a43d54b1e9) - ❌

github-actions bot commented Sep 18, 2023

source-faker test report (commit a43d54b1e9) - ✅

github-actions bot commented Sep 18, 2023

source-file test report (commit a43d54b1e9) - ❌

alafanechere commented Sep 15, 2023 •

edited

Loading

alafanechere commented Sep 15, 2023 •

edited by bnchrch

Loading

source-file test report (commit `c8dbe4db79`) - ❌

source-file-secure test report (commit `e3aebbcdf9`) - ❌

source-file test report (commit `e3aebbcdf9`) - ❌

source-file-secure test report (commit `41c4907fd3`) - ❌

source-faker test report (commit `41c4907fd3`) - ✅

source-file test report (commit `41c4907fd3`) - ❌

source-file-secure test report (commit `b406c99444`) - ❌

source-faker test report (commit `b406c99444`) - ✅

source-file test report (commit `b406c99444`) - ❌

source-file-secure test report (commit `6d77106d62`) - ❌

source-faker test report (commit `6d77106d62`) - ✅

source-file test report (commit `6d77106d62`) - ❌

source-file-secure test report (commit `a43d54b1e9`) - ❌

source-faker test report (commit `a43d54b1e9`) - ✅

source-file test report (commit `a43d54b1e9`) - ❌