Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make certified python connectors use our base image #30528

Closed
wants to merge 39 commits into from
Closed

Make certified python connectors use our base image #30528

wants to merge 39 commits into from

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Sep 18, 2023 •
edited
Loading

What

Closes #30243
Closes #30238

We want:

  • all our python certified connectors to use our new base image.
  • to remove their Dockerfile as it's not used by our build process.
  • to remove their build.gradle file as we have no more use case to build a python connector with gradle.

How

The content of this PR was generated using the following airbyte-ci command locally:
airbyte-ci connectors --support-level=certified migrate-to-base-image 30528

If you're interested in the implementation details of this command please check #30520

Acceptance criteria:

  • The build pass
  • No test regression is observed

TODO

  • Make source-hubspot build pass
  • Make source-zendesk-chat build pass

🚨 User Impact 🚨

When this PR will be merged to master all the certified connector publish pipeline will be triggered and be built and publish using our base image.

This was referenced Sep 18, 2023
Merged
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Merged
@alafanechere Graphite App
Copy link
Contributor Author

alafanechere commented Sep 18, 2023 •
edited by bnchrch
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alafanechere alafanechere mentioned this pull request Sep 18, 2023
Merged
@alafanechere alafanechere changed the title Migrate certified connectors to use our base image Migrate certified python connectors to use our base image Sep 18, 2023
@alafanechere alafanechere changed the title Migrate certified python connectors to use our base image Make certified python connectors use our base image Sep 18, 2023
alafanechere and others added 21 commits September 19, 2023 17:26
@alafanechere
do not push empty commits
02973c0
@alafanechere
set baseImage on source faker
8c556f5
@octavia-squidington-iii @alafanechere
[skip ci]: 🤖 Autocommit on source-faker - Update base image to latest…
4e4a51e 
… version in metadata.yaml
@alafanechere
reword step name in connector test workflow
8d36d0d
@alafanechere
Automated Commit - Format and Process Resources Changes
03892e0
@alafanechere
change our python connector build process to use the base images
a8141e1
@alafanechere
change our python connector build process to use the base images
05cd7ca
@alafanechere
[airbyte-ci] introduce an autocommit command to update base image ver…
4cc9473 
…sion to the latest one
@alafanechere
change our python connector build process to use the base images
2511554
@alafanechere
change our python connector build process to use the base images
4a2bea0
@alafanechere
ref: make format use the new base class
c2d5ad4
@alafanechere
implement version bump comment
07a894c
@alafanechere
add migrate-to-base-image command
5ac1516
@alafanechere
improve build instructions
ccba491
@alafanechere
delete build.gradle on non java connectors
647e8c9
@alafanechere
revert faker changes
f6e7ab5
@alafanechere
[airbyte-ci]: new check on python certified connector to validate the…
9bbd2e2 
…ir base image use
@alafanechere
fix a non awaited coro
11a3b4a
@alafanechere
Empty commit
29b51c3
@alafanechere
Make python certified connectors use our base image, delete their doc…
9367875 
…kerfile and build.gradle file, update docs
@alafanechere
source-zendesk-chat: add build_customization.py
5fd8e9a
@alafanechere alafanechere force-pushed the augustin/09-18-_airbyte-ci_new_check_on_python_certified_connector_to_validate_their_base_image_use branch from 26837a3 to 11a3b4a Compare September 19, 2023 15:28
@alafanechere alafanechere force-pushed the augustin/09-18-migrate-certified-connectors-to-base branch from 6d3a388 to 5fd8e9a Compare September 19, 2023 15:28
@alafanechere alafanechere force-pushed the augustin/09-18-_airbyte-ci_new_check_on_python_certified_connector_to_validate_their_base_image_use branch 3 times, most recently from c013a0a to 8fe96a6 Compare September 20, 2023 11:51
@alafanechere alafanechere marked this pull request as draft September 20, 2023 11:51
@alafanechere alafanechere force-pushed the augustin/09-18-_airbyte-ci_new_check_on_python_certified_connector_to_validate_their_base_image_use branch 2 times, most recently from de9a417 to 29ded3d Compare September 21, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/airtable connectors/source/amazon-ads connectors/source/amplitude connectors/source/bing-ads connectors/source/chargebee connectors/source/facebook-marketing connectors/source/file connectors/source/freshdesk connectors/source/github connectors/source/gitlab connectors/source/google-ads connectors/source/google-analytics-data-api connectors/source/google-analytics-v4 connectors/source/google-search-console connectors/source/google-sheets connectors/source/greenhouse connectors/source/harvest connectors/source/hubspot connectors/source/instagram connectors/source/intercom connectors/source/iterable connectors/source/jira connectors/source/klaviyo connectors/source/linkedin-ads connectors/source/mailchimp connectors/source/marketo connectors/source/mixpanel connectors/source/monday connectors/source/notion connectors/source/paypal-transaction connectors/source/pinterest connectors/source/recharge connectors/source/s3 connectors/source/salesforce connectors/source/sendgrid connectors/source/sentry connectors/source/shopify connectors/source/slack connectors/source/snapchat-marketing connectors/source/stripe connectors/source/surveymonkey connectors/source/tiktok-marketing connectors/source/twilio connectors/source/typeform connectors/source/zendesk-chat connectors/source/zendesk-support connectors/source/zendesk-talk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alafanechere @octavia-squidington-iii