-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[airbyte-ci] change our python connector build process to use our base images #30450
Conversation
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
662ef9b
to
577b1c2
Compare
d882792
to
6f5dfbe
Compare
6f5dfbe
to
4c403fb
Compare
source-zendesk-chat test report (commit
|
Step | Result |
---|
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-zendesk-chat test
source-faker test report (commit
|
Step | Result |
---|
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-faker test
source-file-secure test report (commit
|
Step | Result |
---|
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-file-secure test
4c403fb
to
05e2881
Compare
5c6257a
into
09-14-add_connectorBuildOptions_to_connector_metadata
source-file test report (commit
|
Step | Result |
---|---|
Connector package install | ❌ |
Code format checks | ✅ |
Validate airbyte-integrations/connectors/source-file/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-file test
source-faker test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-faker docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate airbyte-integrations/connectors/source-faker/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-faker test
What
Closes #30236
Make our Python connector build step use the base image versions declared in the
airbyte-connectors-base-images
package.How
BuildConnectorImage
to build a connector from the base image version it defined in the metadata, otherwise fallback to a dockerfile build.TODO
Fix somehting in #30303 to avoid the CI failure.
🚨 User Impact 🚨
This will impact the connector modified in #30449 and other future migrated connector
Next steps:
Implement the pre/post build hook logic: #30237