add connectorBuildOptions.baseImage metadata to a couple of connectors #30449

alafanechere · 2023-09-14T18:54:09Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Community member? Grant edit access to maintainers (instructions)
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Connector version is set to 0.0.1
- Dockerfile has version 0.0.1
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
- docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds then checking in your changes
Documentation which references the generator is updated as needed

alafanechere · 2023-09-14T18:54:20Z

Current dependencies on/for this PR:

master
- PR connector base image: declare the base image package and implement #30303

This comment was auto-generated by Graphite.

github-actions · 2023-09-14T18:54:52Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

…the_base_images' into 09-14-add_connectorBuildOptions_to_connector_metadata

…of github.com:airbytehq/airbyte into 09-14-add_connectorBuildOptions_to_connector_metadata

github-actions · 2023-09-14T23:06:41Z

source-faker test report (commit `af44b36f59`) - ❌

⏲️ Total pipeline duration: 37.93s

Step	Result

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

github-actions · 2023-09-14T23:06:47Z

source-file-secure test report (commit `af44b36f59`) - ❌

⏲️ Total pipeline duration: 01mn20s

Step	Result

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

github-actions · 2023-09-14T23:47:14Z

source-file-secure test report (commit `d6d2872b52`) - ❌

⏲️ Total pipeline duration: 26.69s

Step	Result

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

github-actions · 2023-09-15T00:06:17Z

source-file test report (commit `d6d2872b52`) - ❌

⏲️ Total pipeline duration: 20mn04s

Step	Result
Connector package install	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-file/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

github-actions · 2023-09-15T00:09:19Z

source-faker test report (commit `461541bc53`) - ❌

⏲️ Total pipeline duration: 42.37s

Step	Result

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

github-actions · 2023-09-15T00:09:19Z

source-file-secure test report (commit `461541bc53`) - ❌

⏲️ Total pipeline duration: 42.81s

Step	Result

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

github-actions · 2023-09-15T00:09:20Z

source-zendesk-chat test report (commit `461541bc53`) - ❌

⏲️ Total pipeline duration: 55.54s

Step	Result

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-chat test

github-actions · 2023-09-15T00:28:24Z

source-file test report (commit `461541bc53`) - ❌

⏲️ Total pipeline duration: 20mn16s

Step	Result
Connector package install	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-file/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

octavia-squidington-iii added the area/connectors Connector related issues label Sep 14, 2023

This was referenced Sep 14, 2023

connector base image: declare the base image package and implement #30303

Merged

[airbyte-ci] change our python connector build process to use our base images #30450

Merged

octavia-squidington-iii added connectors/source/file connectors/source/zendesk-chat connectors/source/file-secure connectors/source/faker labels Sep 14, 2023

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 14, 2023

alafanechere added 3 commits September 15, 2023 00:35

add connectorBuildOptions to connector metadata

9a59a63

bump versions

7b2d7bd

fix connector base image for source-file

577b1c2

alafanechere force-pushed the 09-14-add_connectorBuildOptions_to_connector_metadata branch from 662ef9b to 577b1c2 Compare September 14, 2023 22:36

alafanechere changed the base branch from augustin/declare-first-base-image to 09-14-change_our_python_connector_build_process_to_use_the_base_images September 14, 2023 22:45

Merge branch '09-14-change_our_python_connector_build_process_to_use_…

5c6257a

…the_base_images' into 09-14-add_connectorBuildOptions_to_connector_metadata

alafanechere deleted the branch 09-15-make_QA_checks_handle_missing_dockerfiles September 14, 2023 22:46

alafanechere closed this Sep 14, 2023

alafanechere reopened this Sep 14, 2023

alafanechere mentioned this pull request Sep 14, 2023

[airbyte-ci] build python connectors from base images #30456

Merged

alafanechere added 7 commits September 15, 2023 00:58

add connectorBuildOptions to connector metadata

ab76163

bump versions

8baa349

fix connector base image for source-file

4cc34aa

Merge branch '09-14-add_connectorBuildOptions_to_connector_metadata' …

cbadd03

…of github.com:airbytehq/airbyte into 09-14-add_connectorBuildOptions_to_connector_metadata

Merge branch '09-14-add_connectorBuildOptions_to_connector_metadata' …

1231001

…of github.com:airbytehq/airbyte into 09-14-add_connectorBuildOptions_to_connector_metadata

Merge branch '09-14-add_connectorBuildOptions_to_connector_metadata' …

4d5c96e

…of github.com:airbytehq/airbyte into 09-14-add_connectorBuildOptions_to_connector_metadata

remove dockerfiles

af44b36

alafanechere marked this pull request as ready for review September 14, 2023 23:04

alafanechere added 12 commits September 15, 2023 01:51

optional dockerfile check

be8c83f

make QA checks handle missing dockerfiles

760a755

add connectorBuildOptions to connector metadata

caeaf82

bump versions

9ba0e6c

fix connector base image for source-file

07b5f20

remove dockerfiles

2b35b08

better changelog

3e80f96

bump versions

c107a80

remove dockerfiles

f931474

better changelog

b5267f6

Trigger CI/CD pipeline

4c61eb1

fix conflict

461541b

alafanechere closed this Sep 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add connectorBuildOptions.baseImage metadata to a couple of connectors #30449

add connectorBuildOptions.baseImage metadata to a couple of connectors #30449

alafanechere commented Sep 14, 2023

alafanechere commented Sep 14, 2023 •

edited

Loading

github-actions bot commented Sep 14, 2023 •

edited

Loading

github-actions bot commented Sep 14, 2023

github-actions bot commented Sep 14, 2023

github-actions bot commented Sep 14, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

add connectorBuildOptions.baseImage metadata to a couple of connectors #30449

add connectorBuildOptions.baseImage metadata to a couple of connectors #30449

Conversation

alafanechere commented Sep 14, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

alafanechere commented Sep 14, 2023 • edited Loading

github-actions bot commented Sep 14, 2023 • edited Loading

Before Merging a Connector Pull Request

github-actions bot commented Sep 14, 2023

source-faker test report (commit af44b36f59) - ❌

github-actions bot commented Sep 14, 2023

source-file-secure test report (commit af44b36f59) - ❌

github-actions bot commented Sep 14, 2023

source-file-secure test report (commit d6d2872b52) - ❌

github-actions bot commented Sep 15, 2023

source-file test report (commit d6d2872b52) - ❌

github-actions bot commented Sep 15, 2023

source-faker test report (commit 461541bc53) - ❌

github-actions bot commented Sep 15, 2023

source-file-secure test report (commit 461541bc53) - ❌

github-actions bot commented Sep 15, 2023

source-zendesk-chat test report (commit 461541bc53) - ❌

github-actions bot commented Sep 15, 2023

source-file test report (commit 461541bc53) - ❌

alafanechere commented Sep 14, 2023 •

edited

Loading

github-actions bot commented Sep 14, 2023 •

edited

Loading

source-faker test report (commit `af44b36f59`) - ❌

source-file-secure test report (commit `af44b36f59`) - ❌

source-file-secure test report (commit `d6d2872b52`) - ❌

source-file test report (commit `d6d2872b52`) - ❌

source-faker test report (commit `461541bc53`) - ❌

source-file-secure test report (commit `461541bc53`) - ❌

source-zendesk-chat test report (commit `461541bc53`) - ❌

source-file test report (commit `461541bc53`) - ❌