Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snowflake Destination: Upgrade CDK #34462

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Snowflake Destination: Upgrade CDK #34462

merged 7 commits into from
Jan 24, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jan 23, 2024

What

  • Upgrade Snowflake to pick the reverted CDK changes to move forward.

@gisripa gisripa requested a review from a team as a January 23, 2024 22:56
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 5:38pm

@gisripa gisripa mentioned this pull request Jan 23, 2024
Merged
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jan 23, 2024
@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Jan 23, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited by gisripa
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

edgao
edgao approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, otherwise lgtm

...ava/io/airbyte/integrations/destination/snowflake/SnowflakeInternalStagingSqlOperations.java Outdated Show resolved Hide resolved
@gisripa gisripa force-pushed the gireesh/01-23-gireesh/cdk/resurrect-breaking branch from 3e317bd to 4576631 Compare January 24, 2024 00:21
@gisripa gisripa force-pushed the gireesh/01-23-snowflake/cdk-update branch from 69f4414 to b7a7016 Compare January 24, 2024 00:21
@gisripa gisripa force-pushed the gireesh/01-23-gireesh/cdk/resurrect-breaking branch from 4576631 to 0f51dba Compare January 24, 2024 00:51
@gisripa gisripa force-pushed the gireesh/01-23-snowflake/cdk-update branch from b7a7016 to c746018 Compare January 24, 2024 00:52
@gisripa gisripa force-pushed the gireesh/01-23-gireesh/cdk/resurrect-breaking branch from 0f51dba to bc0697b Compare January 24, 2024 00:58
@gisripa gisripa force-pushed the gireesh/01-23-snowflake/cdk-update branch from f826337 to 0dea543 Compare January 24, 2024 00:58
This was referenced Jan 24, 2024
Merged
Merged
@gisripa gisripa force-pushed the gireesh/01-23-gireesh/cdk/resurrect-breaking branch from 6e46415 to 1171ebc Compare January 24, 2024 17:17
@gisripa gisripa force-pushed the gireesh/01-23-snowflake/cdk-update branch from a283318 to 15c75e3 Compare January 24, 2024 17:32
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 24, 2024
Base automatically changed from gireesh/01-23-gireesh/cdk/resurrect-breaking to master January 24, 2024 18:08
@gisripa gisripa merged commit 950fea1 into master Jan 24, 2024
31 of 36 checks passed
@gisripa gisripa deleted the gireesh/01-23-snowflake/cdk-update branch January 24, 2024 18:09
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Snowflake Destination: Upgrade CDK (airbytehq#34462)
32a316c 
## What
* Upgrade Snowflake to pick the reverted CDK changes to move forward.
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Snowflake Destination: Upgrade CDK (airbytehq#34462)
3b4166a 
## What
* Upgrade Snowflake to pick the reverted CDK changes to move forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/destination/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gisripa @edgao @octavia-squidington-iii