Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Redshift: Update CDK, revert signatures to add back unused methods and vars #34467

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Destination Redshift: Update CDK, revert signatures to add back unused methods and vars #34467

merged 6 commits into from
Jan 24, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jan 24, 2024

@gisripa gisripa requested a review from a team as a January 24, 2024 01:36
@vercel Vercel
Copy link

vercel bot commented Jan 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 5:32pm

@gisripa gisripa mentioned this pull request Jan 24, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024 •
edited by gisripa
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Jan 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

This was referenced Jan 24, 2024
Merged
Merged
@gisripa gisripa force-pushed the gireesh/01-23-gireesh/cdk/resurrect-breaking branch from 6e46415 to 1171ebc Compare January 24, 2024 17:17
@gisripa gisripa force-pushed the gireesh/01-23-redshift/cdk-update branch from 4debdcc to 6fbabf8 Compare January 24, 2024 17:21
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 24, 2024
Base automatically changed from gireesh/01-23-gireesh/cdk/resurrect-breaking to master January 24, 2024 18:08
@gisripa gisripa merged commit 7123222 into master Jan 24, 2024
27 of 29 checks passed
@gisripa gisripa deleted the gireesh/01-23-redshift/cdk-update branch January 24, 2024 18:09
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Destination Redshift: Update CDK, revert signatures to add back unuse…
10539e6 
…d methods and vars (airbytehq#34467)

## What
* Reverting few signature changes from airbytehq#34186
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Destination Redshift: Update CDK, revert signatures to add back unuse…
6e7b9ba 
…d methods and vars (airbytehq#34467)

## What
* Reverting few signature changes from airbytehq#34186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/destination/redshift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gisripa @edgao @octavia-squidington-iii