Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-google-sheets: use poetry for dependency management [2] #35008

Merged

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Feb 8, 2024

Re-introduce the reverted #34944

  • fix the publish

What

Relates to #34958

  • airbyte-lib overrides the package name with a airbyte- prefix.
  • By default poetry expects the root package to be named accordingly (airbyte_source_google_sheets), but the root package is name source_google_sheets)

How

  • Explicitely set the package to include in the tool.poetry.package section of pyproject.toml

Confirmed a successful pre-release

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 11:18am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@alafanechere alafanechere force-pushed the augustin/source-google-sheets-poetry-publish-fix branch from 8e5ddf7 to 8b3a6a7 Compare February 8, 2024 10:29
@alafanechere alafanechere requested a review from a team as a code owner February 8, 2024 10:29
@alafanechere alafanechere changed the base branch from master to augustin/02-08-airbyte-ci_poetry_install_--no-root_in_builder February 8, 2024 10:29
Copy link
Contributor Author

alafanechere commented Feb 8, 2024

@alafanechere alafanechere force-pushed the augustin/source-google-sheets-poetry-publish-fix branch from 8b3a6a7 to 4c4ca48 Compare February 8, 2024 10:47
@alafanechere alafanechere changed the base branch from augustin/02-08-airbyte-ci_poetry_install_--no-root_in_builder to augustin/02-08-publish-workflow_expose_airbyte-ci-binary-url_input February 8, 2024 10:47
@alafanechere alafanechere force-pushed the augustin/02-08-publish-workflow_expose_airbyte-ci-binary-url_input branch from 5498158 to 2d67b39 Compare February 8, 2024 11:03
@alafanechere alafanechere force-pushed the augustin/source-google-sheets-poetry-publish-fix branch from 4c4ca48 to e833bf6 Compare February 8, 2024 11:03
@alafanechere alafanechere force-pushed the augustin/02-08-publish-workflow_expose_airbyte-ci-binary-url_input branch from 2d67b39 to a8b0f98 Compare February 8, 2024 11:09
@alafanechere alafanechere force-pushed the augustin/source-google-sheets-poetry-publish-fix branch from e833bf6 to f66d79b Compare February 8, 2024 11:09
Base automatically changed from augustin/02-08-publish-workflow_expose_airbyte-ci-binary-url_input to master February 8, 2024 11:16
@alafanechere alafanechere force-pushed the augustin/source-google-sheets-poetry-publish-fix branch from f66d79b to 2f06214 Compare February 8, 2024 11:18
@alafanechere alafanechere merged commit 890d9e0 into master Feb 8, 2024
22 of 23 checks passed
@alafanechere alafanechere deleted the augustin/source-google-sheets-poetry-publish-fix branch February 8, 2024 11:41
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-sheets poetry-migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants