Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: poetry install --no-root in builder #35010

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Feb 8, 2024

What

When we build a connector image using poetry we run poetry install in a builder container to which we only mount pyproject.toml and poetry.lock to install the dependencies.
We then pass the installed deps to another container by mounting them to /usr/local.

When running poetry install in this builder container (which only has pyproject.toml) the command tries to install the package listed under tool.poetry.package, but these package code is not in the builder container.

How

We can fix it running poetry install --no-root to only install dependencies in a builder container.

@alafanechere alafanechere requested a review from a team as a code owner February 8, 2024 10:28
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 10:28am

Copy link
Contributor Author

alafanechere commented Feb 8, 2024

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and build still works and is fast on changing code only

@alafanechere alafanechere merged commit 9141d70 into master Feb 8, 2024
25 checks passed
@alafanechere alafanechere deleted the augustin/02-08-airbyte-ci_poetry_install_--no-root_in_builder branch February 8, 2024 10:50
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants