Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further clarify where to run deployment commands in EC2/GCP deployments #3537

Merged
merged 1 commit into from
May 21, 2021
Merged

Further clarify where to run deployment commands in EC2/GCP deployments #3537

merged 1 commit into from
May 21, 2021

Conversation

avaidyanatha
Copy link
Contributor

@avaidyanatha avaidyanatha commented May 21, 2021 •
edited
Loading

Main Changes

  • We've been seeing a bit of confusion on where people need to run commands during the deployment process. This clarifies the language around that for our EC2 deployment instructions and our GCP deployment instructions.

Misc Changes

  • This also adds in the instructions for installing gcloud on Linux

Notes

@avaidyanatha avaidyanatha added the area/documentation Improvements or additions to documentation label May 21, 2021
@avaidyanatha avaidyanatha changed the title Further clarify confusion between where to run deployment commands wh… Further clarify where to run deployment commands in EC2/GCP deployments May 21, 2021
sherifnada
sherifnada approved these changes May 21, 2021
View reviewed changes
docs/deploying-airbyte/on-gcp-compute-engine.md
@@ -45,7 +45,10 @@ gcloud init # Follow instructions

{% tab title="Ubuntu" %}
```bash
# FIXME
echo "deb [signed-by=/usr/share/keyrings/cloud.google.gpg] https://packages.cloud.google.com/apt cloud-sdk main" | sudo tee -a /etc/apt/sources.list.d/google-cloud-sdk.list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm assuming you've tested these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I have a machine with Ubuntu on it, I might use it to update all of our docs with instructions for Ubuntu.

@avaidyanatha avaidyanatha merged commit 3fbb382 into master May 21, 2021
@avaidyanatha avaidyanatha deleted the abhi/land-of-confusion branch May 21, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@cgardens cgardens Awaiting requested review from cgardens

@ChristopheDuong ChristopheDuong Awaiting requested review from ChristopheDuong

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusion around SSH/Local Workstation in Docs
2 participants
@avaidyanatha @sherifnada