Source Google Sheets: address dependency conflict and update CDK #36515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
ChristoGrab
commented
Mar 26, 2024
| @@ -12,18 +12,15 @@ readme = "README.md" | |||
| documentation = "https://docs.airbyte.com/integrations/sources/google-sheets" | |||
| homepage = "https://airbyte.com" | |||
| repository = "https://github.com/airbytehq/airbyte" | |||
| packages = [ { include = "source_google_sheets"}] | |||
| [[tool.poetry.packages]] | |||
There was a problem hiding this comment.
I changed this line because it didn't match the pattern from other connectors. My understanding is that it's functionally the same given we're only listing a single package, but I figure it's safest to be sticklers for conformity within the poetry setup.
msaffitz
added a commit
to Encore-Post-Sales/airbyte-magnify
that referenced
this pull request
Apr 3, 2024
* master: (1562 commits) ✨ source-google-drive: migrate to poetry (airbytehq#36581) enable spotbugs for CDK core and dependencies submodule (airbytehq#36612) ✨ Source Salesforce, Shopify: add maxSecondsBetweenMessages in metadata (airbytehq#36723) java-cdk: re-export airbyte-api dependency (airbytehq#36759) Source Google Sheets: address dependency conflict and update CDK (airbytehq#36515) Airbyte CI: rename incorrectly named pipelines (airbytehq#36722) Source Azure Blob Storage: add integration tests (airbytehq#36542) Salesforce: retry on download_data and create_stream_job (airbytehq#36385) ✨Source Monday: Bumped CDK version dependency (airbytehq#36746) airbyte-ci: burst gradle task cache on new java cdk release (airbytehq#36480) chore(connectors): remove tasks.py and top-level requirements.txt (airbytehq#36738) airbyte-ci: fix pull-request-number option for migrate_to_base_image (airbytehq#36779) 🤖 Bump patch version of Python CDK add backward compatibility for an old close slice logic (airbytehq#36774) Bump Airbyte version from 0.57.0 to 0.57.1 🤖 Bump patch version of Python CDK low-code: Fix cursor pagination instantiation if the stop_condition is a string (airbytehq#36760) fix rabbitmq icon and simplify docs registry code (airbytehq#36767) Update azure-entra-id.md (airbytehq#36758) re-enable rabbitmq on OSS (airbytehq#36749) ...
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
markcusack
pushed a commit
to markcusack/airbyte
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The CDK version for source Google Sheets was recently unpinned, but it turns out the lock file was silently failing to update the package version above
0.51.8, even when explicitly runningpoetry update airbyte-cdk. Investigation pointed to the cause being dependencies which come pre-packaged in the CDK also being listed separately in thepyprojectfile (namelybackoff,pydantic,pyYAMLandrequests).How
airbyte-cdkfrompyprojectfile and updatepoetry.lock_readmethod to correctly pass expectedAirbyteStreaminstance to theas_airbyte_messagemethod.