Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backward compatibility for an old close slice logic #36774

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Apr 3, 2024

What

with this PR was deleted an old cursor calculation logic and most_recent_record not longer transferred to close_slice method - here what can be result for broken streams with an old logic in custom components.

How

  • add *arg to cursor classes
  • revert old behavior in simple retriever

@lazebnyi lazebnyi requested a review from a team as a code owner April 3, 2024 00:23
Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 1:06am

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 3, 2024
@lazebnyi lazebnyi requested a review from girarda April 3, 2024 00:36
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lazebnyi lazebnyi merged commit 033decc into master Apr 3, 2024
28 checks passed
@lazebnyi lazebnyi deleted the lazebnyi/low_code_fix_curor_close_slice branch April 3, 2024 01:13
msaffitz added a commit to Encore-Post-Sales/airbyte-magnify that referenced this pull request Apr 3, 2024
* master: (1562 commits)
  ✨ source-google-drive: migrate to poetry  (airbytehq#36581)
  enable spotbugs for CDK core and dependencies submodule (airbytehq#36612)
  ✨ Source Salesforce, Shopify: add maxSecondsBetweenMessages in metadata (airbytehq#36723)
  java-cdk: re-export airbyte-api dependency (airbytehq#36759)
  Source Google Sheets: address dependency conflict and update CDK (airbytehq#36515)
  Airbyte CI: rename incorrectly named pipelines (airbytehq#36722)
  Source Azure Blob Storage: add integration tests (airbytehq#36542)
  Salesforce: retry on download_data and create_stream_job (airbytehq#36385)
  ✨Source Monday: Bumped CDK version dependency (airbytehq#36746)
  airbyte-ci: burst gradle task cache on new java cdk release (airbytehq#36480)
  chore(connectors): remove tasks.py and top-level requirements.txt (airbytehq#36738)
  airbyte-ci: fix pull-request-number option for migrate_to_base_image (airbytehq#36779)
  🤖 Bump patch version of Python CDK
  add backward compatibility for an old close slice logic (airbytehq#36774)
  Bump Airbyte version from 0.57.0 to 0.57.1
  🤖 Bump patch version of Python CDK
  low-code: Fix cursor pagination instantiation if the stop_condition is a string (airbytehq#36760)
  fix rabbitmq icon and simplify docs registry code (airbytehq#36767)
  Update azure-entra-id.md (airbytehq#36758)
  re-enable rabbitmq on OSS (airbytehq#36749)
  ...
nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants