🐛 Source Salesforce: have clear error when stream preparation fails #37105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
maxi297
commented
Apr 12, 2024
airbyte-integrations/connectors/source-salesforce/source_salesforce/api.py
Show resolved
Hide resolved
maxi297
changed the title
octavia-squidington-iii
added
the
area/documentation
bazarnov
approved these changes
Apr 13, 2024
maxi297
deleted the
issue-6888/salesforce-have-clear-error-when-stream-preparation-fails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Addresses https://github.com/airbytehq/airbyte-internal-issues/issues/6888 where a stream instantiation problem would cause cursor issue.
How
The version 2.4.1 already added retries on this call so we don't expect to see the problem anymore. However, if it occurs, we want the error to be clear. Hence, a traced exception has been added.
Proposed reading order
🚨 User Impact 🚨
None as we don't expect the error to come up anymore but if it does, we will have a better error message than before.