-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Jira: migration to low-code #37374
Source Jira: migration to low-code #37374
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
airbyte-integrations/connectors/source-jira/source_jira/config_migrations.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-jira/source_jira/manifest.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-jira/source_jira/components/partition_routers.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting I tested the change here and the result looks good. We should still re-test after the next round of changes but this is moving in the right direction
- remove unused comments - add custom component description
95a7fc1
to
feec1be
Compare
airbyte-integrations/connectors/source-jira/source_jira/components/partition_routers.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regression tests look good. Approved pending answering the remaining questions and @katmarkham's review of the breaking change notice
@girarda I have answered questions and run another round of regression tests after all the changes were made, and the results are good. |
What
Migration from python to low-code for Jira connector.
How
Most streams have been migrated successfully, except two incremental streams that require incremental synchronization for their parent stream as well. Those streams are:
The
PullRequests
stream is also considered to be a Python stream because it requires a lot of customization.This migration is a breaking change due to the incompatibility between the old and new states. The
LegacyToPerPartitionStateMigration
component cannot be used for the state migration. Additionally, an issue in theProjectAvatars
stream has been fixed, where a field was defined as 'project_id,' when in reality, it holds a project key (now it holds project id).