Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Jira: migration to low-code #37374

Merged
merged 48 commits into from
May 13, 2024

Conversation

roman-yermilov-gl
Copy link
Contributor

@roman-yermilov-gl roman-yermilov-gl commented Apr 17, 2024

What

Migration from python to low-code for Jira connector.

How

Most streams have been migrated successfully, except two incremental streams that require incremental synchronization for their parent stream as well. Those streams are:

  • IssueComments
  • IssueWorklogs

The PullRequests stream is also considered to be a Python stream because it requires a lot of customization.

This migration is a breaking change due to the incompatibility between the old and new states. The LegacyToPerPartitionStateMigration component cannot be used for the state migration. Additionally, an issue in the ProjectAvatars stream has been fixed, where a field was defined as 'project_id,' when in reality, it holds a project key (now it holds project id).

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 4:44pm

@tolik0 tolik0 marked this pull request as ready for review April 18, 2024 14:57
@octavia-squidington-iv octavia-squidington-iv requested review from a team April 18, 2024 14:59
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting I tested the change here and the result looks good. We should still re-test after the next round of changes but this is moving in the right direction

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regression tests look good. Approved pending answering the remaining questions and @katmarkham's review of the breaking change notice

@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented May 8, 2024

@girarda I have answered questions and run another round of regression tests after all the changes were made, and the results are good.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team May 9, 2024 14:19
@roman-yermilov-gl roman-yermilov-gl merged commit b2bdfb0 into master May 13, 2024
38 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-jira-migrate-to-low-code branch May 13, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants