-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Intercom: Add tickets stream #39117
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -10,7 +10,7 @@ data: | |||
connectorSubtype: api | |||
connectorType: source | |||
definitionId: d8313939-3782-41b0-be29-b3ca20d8dd3a | |||
dockerImageTag: 0.6.6 | |||
dockerImageTag: 0.6.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krishan711 new streams are a minor update can you change to 0.7.0 and also bump the version in project.toml and run poetry lock? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
If possible update the description of the contribution and link an existing issue or discussion. |
Thanks, updated the description. please let me know what i should add more detail about if anything. |
@krishan711 running CI, let's wait for the results. |
@marcosmarxm i cant tell what i need to do to make these checks pass. could i get some guidance here by any chance pls? |
What
I've added the tickets stream so we can pull issues from intercom as shown in their API: https://developers.intercom.com/docs/references/rest-api/api.intercom.io/Tickets/ticket/
How
I created a new stream called
tickets
.Review guide
User Impact
Nothing changed in existing streams, just a new stream added.
Can this PR be safely reverted and rolled back?