Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Intercom: Add tickets stream #39117

Closed
wants to merge 17 commits into from

Conversation

krishan711
Copy link

@krishan711 krishan711 commented Jun 5, 2024

What

I've added the tickets stream so we can pull issues from intercom as shown in their API: https://developers.intercom.com/docs/references/rest-api/api.intercom.io/Tickets/ticket/

How

I created a new stream called tickets.

Review guide

User Impact

Nothing changed in existing streams, just a new stream added.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 9:32am

@@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: d8313939-3782-41b0-be29-b3ca20d8dd3a
dockerImageTag: 0.6.6
dockerImageTag: 0.6.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishan711 new streams are a minor update can you change to 0.7.0 and also bump the version in project.toml and run poetry lock? Thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do, thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@marcosmarxm
Copy link
Member

If possible update the description of the contribution and link an existing issue or discussion.

@krishan711
Copy link
Author

If possible update the description of the contribution and link an existing issue or discussion.

Thanks, updated the description. please let me know what i should add more detail about if anything.

@marcosmarxm
Copy link
Member

@krishan711 running CI, let's wait for the results.

@krishan711
Copy link
Author

@marcosmarxm i cant tell what i need to do to make these checks pass. could i get some guidance here by any chance pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/intercom Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants