Skip to content

Conversation

McJoppy
Copy link

@McJoppy McJoppy commented Jul 21, 2024

eg. setter for api root added as comment in examples/BASIC/BASIC.ino

@airgradienthq airgradienthq requested a review from pnt325 August 12, 2024 02:29
@airgradienthq
Copy link
Owner

@pnt325 Is that change also in the other example files?

@pnt325
Copy link
Contributor

pnt325 commented Aug 12, 2024

@pnt325 Is that change also in the other example files?

Yes, all example that use http client need to update. This PR update for BASIC.ino only

@McJoppy
Copy link
Author

McJoppy commented Aug 12, 2024

I only have the ability to test on hardware using the basic example which is why I only updated that.

I'll add the changes to the other examples too.

@airgradienthq
Copy link
Owner

@McJoppy Are you updating the pull request with the other examples too?

@McJoppy
Copy link
Author

McJoppy commented Aug 18, 2024

I've now included comments in each example for changing APIROOT to align with BASIC.ino

@airgradienthq airgradienthq changed the base branch from master to develop August 20, 2024 02:13
@airgradienthq airgradienthq merged commit fb57a11 into airgradienthq:develop Aug 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants