correct pm2.5 formula to show value on display #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-4711
reviewed
Aug 15, 2024
src/AgOledDisplay.cpp
Outdated
| @@ -304,6 +304,10 @@ void OledDisplay::showDashboard(const char *status) { | |||
| DISP()->drawStr(55, 27, "PM2.5"); | |||
|
|
|||
| /** Draw PM2.5 value */ | |||
| int pm25 = value.pm25_1; | |||
| if (config.hasSensorSHT) { | |||
| pm25 = ag->pms5003.pm25Compensated(pm25, value.Humidity); | |||
There was a problem hiding this comment.
propose to rename the method to simply .compensate(). We can see from the params that this is related to pm25.
There was a problem hiding this comment.
Ok, I'll change the name and update API comment to mention the input is PM2.5
nick-4711
reviewed
Aug 15, 2024
src/PMS/PMS.cpp
Outdated
| * | ||
| * @param pm25 Raw PM2.5 value | ||
| * @param humidity Humidity value (%) | ||
| * @return float |
There was a problem hiding this comment.
it returns an int? Propose to write
@return the compensated PM2.5 value
There was a problem hiding this comment.
Yes, it's return the int. I'll update the method comment
nick-4711
reviewed
Aug 15, 2024
| * @return float | ||
| */ | ||
| int PMSBase::pm25Compensated(int pm25, float humidity) { | ||
| float value; |
There was a problem hiding this comment.
We need to link to the documentation where this is from
There was a problem hiding this comment.
@airgradienthq please add your document for this formula.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the PM2.5 calculate formula #182 . The correct value show on device display or use on local only.