Include PMS particle count 0.5 and 5.0 #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Payload already print out on toString() measurement
nick-4711
reviewed
Nov 1, 2024
nick-4711
reviewed
Nov 1, 2024
src/AgValue.cpp
Outdated
| utils::isValidPm03Count(_pm_05_pc[1].update.avg)) { | ||
| float avg = (_pm_05_pc[0].update.avg + _pm_05_pc[1].update.avg) / 2.0f; | ||
| pms["pm005Count"] = ag.round2(avg); | ||
| pms["channels"]["1"]["pm005Count"] = ag.round2(_pm_05_pc[0].update.avg); |
There was a problem hiding this comment.
005 vs 05, I think we should align this to avoid confusion
There was a problem hiding this comment.
I just follow the existing formatting. Is it better if we use pms05Count and pms50Count or pms5Count? If yes, shouldn't we need to update other field too then?
There was a problem hiding this comment.
Changes
pm25Counttopm02Countpm05Counttopm50Count
Detail on local-server.md
nick-4711
reviewed
Nov 1, 2024
| @@ -136,13 +136,27 @@ int PMS5003::getPm03ParticleCount(void) { | |||
| */ | |||
| int PMS5003::getPm01ParticleCount(void) { return pms.getCount1_0(); } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
I think such descriptions don't provide any value, the same information is already included in the method signature. Propose to gradually remove these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
New measurements
0.5and5.0. Except5.0only for indoor monitor.New field on json payload
pm005Countpm50CountUpdated field on json payload
pm02CountSee
docs/local-server.mdfor more detail of each field above