fix: don't contact AG server if cloud connection is disabled #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hestiahacker , this problem should already fixed on this #278 . You could try the latest firmware version which is 3.2.0. |
|
Oops. Sorry about that, closing this PR now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue where the firmware calls out to the AirGradient server even when "Prevent Connection to AirGradient Server" is checked.
This was brought up in the ability to turn off data to external networks post.
It was mentioned in the forum that there is an intent to fix this issue.
This change needs tested to verify it completely disables all connections to the AG server. It compiles fine, but I haven't done a full network analysis to confirm it doesn't call out elsewhere or cause any other problem by no longer fetching the server configuration.