Report PM data to metrics API for AirGradient ONE #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @danielmoore Phat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that PM 0.1, 2.5, and 1.0 data on my AirGradient ONE was being reported by
/measures/currentbut not/metrcis. This MR brings those two endpoints better into parity.I also noticed a comma went missing causing Prometheus to no longer be able to parse the metrics. Fixed that, too.
As a side note, I notice that the logic for handling a measurement seems to be duplicated between
AgValue.cppandOpenMetrics.cpp. I suspect we'll keep seeing this kind of disparity between these endpoints until that logic is unified.