Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install an airsdk without AIR on macOS and linux #65

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

j3k0
Copy link
Contributor

@j3k0 j3k0 commented Oct 1, 2021

Implements the functionality with bash.

Depends on python, curl and unzip (which are present by default on macOS, AFAIK).


Note: I realize this only supports macOS at the moment, as the download URL used here is the one for macOS. The correct link can be figured out by checking the OS with uname.

Note 2: Maybe setting license=accepted is a little borderline? What could be done? I'm thinking an environment variable AIRSDK_ACCEPT_LICENSE=yes (DONE)

Implements the functionality with bash.

Depends on python, curl, unzip.
@marchbold
Copy link
Contributor

Interesting idea!

The reason we haven't been down this path is that we are hoping to eventually use a captive runtime app for APM which would negate this need. However this approach could be a decent intermediate one if you could find an equivalent approach for windows?

@j3k0
Copy link
Contributor Author

j3k0 commented Oct 4, 2021

...equivalent approach for windows?

Not having used a windows computer since 1998, I have very little idea how you would do this.

Maybe from the batch script (apm.bat) or by building a native launcher tool apm.exe (.NET? Java? Whichever windows computer might have by default). The tool will forward all calls to the swf cli, except the SDK download features, implemented natively.

@j3k0
Copy link
Contributor Author

j3k0 commented Oct 7, 2021

So can this be merged before a windows implementation is available? I'm using the feature so I can rely on apm to install the AIR SDK on our CI pipeline. If it can't be merged in, I'll move this code to an external tool.

@marchbold
Copy link
Contributor

I suggest moving this to an external tool currently, as we are still in discussions with Harman around an sdk manager and the direction of the airsdk commands. We may be moving them to a separate tool.

Copy link
Contributor

@marchbold marchbold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got an additional issue with this one.

This script is used on windows under WSL and GitBash clients where python isn't installed by default. Seems curl and unzip are at least available in the couple of machines i've tested.

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants