Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1695] Twilio SMS does not display the channelSourceId correctly #1703

Merged
merged 2 commits into from
May 4, 2021
Merged

[#1695] Twilio SMS does not display the channelSourceId correctly #1703

merged 2 commits into from
May 4, 2021

Conversation

AudreyKj
Copy link
Contributor

@AudreyKj AudreyKj commented May 3, 2021 •
edited
Loading

closes #1695

  • if the channel does not have a name, we want to display the channel source (for channels that are not from a Twilio source), or the phone number for Twilio sources

@github-actions github-actions bot added the fix label May 3, 2021
AitorAlgorta
AitorAlgorta approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@AitorAlgorta AitorAlgorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AitorAlgorta AitorAlgorta merged commit 2d86652 into develop May 4, 2021
@AitorAlgorta AitorAlgorta deleted the fix/1695-twilio-sms-does-not-display-the-channelsourceid-correctly branch May 4, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AitorAlgorta AitorAlgorta AitorAlgorta approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Twilio SMS does not display the channelSourceId correctly
2 participants
@AudreyKj @AitorAlgorta