Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1736] improve render library for facebook #1756

Merged
merged 3 commits into from
May 10, 2021
Merged

[#1736] improve render library for facebook #1756

merged 3 commits into from
May 10, 2021

Conversation

AudreyKj
Copy link
Contributor

@AudreyKj AudreyKj commented May 7, 2021 •
edited
Loading

closes #1736

changes:

  • enabled links in messages
  • added Facebook Fallback attachment (mainly used for URLs)
  • improved FB render library to support text sent with attachments

screenshots

Fallback attachment example (text / title / URL)

Screenshot 2021-05-07 at 16 29 09

Text with attachment example

Screenshot 2021-05-07 at 16 28 05

@AudreyKj AudreyKj requested a review from stayprodio May 7, 2021 15:06
@github-actions github-actions bot added the fix label May 7, 2021
@AudreyKj AudreyKj requested a review from AitorAlgorta May 7, 2021 15:07
@AudreyKj AudreyKj merged commit 5ad9f8a into develop May 10, 2021
@AudreyKj AudreyKj deleted the fix/1736-improve-render-library-for-facebook branch May 10, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucapette lucapette lucapette approved these changes

@stayprodio stayprodio Awaiting requested review from stayprodio

@AitorAlgorta AitorAlgorta Awaiting requested review from AitorAlgorta

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve render library for facebook
2 participants
@AudreyKj @lucapette