[#1808] Improved lastMessageSent #1821
Conversation
| const lastMessageContent = conversation.lastMessage.content; | ||
|
|
||
| if (typeof lastMessageContent === 'string') { |
There was a problem hiding this comment.
This code should be in the rendering library, right?
There was a problem hiding this comment.
it is in the rendering lib, we just didn't use it. We should refactor the conversationListItem so it uses the render lib for every source, don't we @AitorAlgorta @chrismatix
There was a problem hiding this comment.
Do we really want to use the render lib also fro the preview of the message? I am not sure what is best
There was a problem hiding this comment.
I think we should use the render lib to show the preview of the message, that way it shows more of a description than just an icon
There was a problem hiding this comment.
@AitorAlgorta Picking up on your other comment: Doing it in the render library is simpler, because each renderer is split into a mapper and a renderer. The SourceMessagePreview can re-use the mapper part. This is reason why I did the split in the first place :)
Furthermore, we can simplify the preview into "text" vs "something else" (images, data, audio, etc.) to make the components simpler. So we add two components and then a SourceMessagePreview, where every source uses its mapper and then maps text to the text component and anything else to the "something else" (data) component.
| source={conversation.channel.source} | ||
| contentType="message" | ||
| content={conversation.lastMessage} | ||
| isTwilioConversationListItem={true} |
There was a problem hiding this comment.
The API of the render library needs to be source agnostic. What does this attribute change?
There was a problem hiding this comment.
the styling of the message itself, so it not a bubble as in messageList @chrismatix
There was a problem hiding this comment.
I agree with @chrismatix the render lib should be agnostic. That's what I meant in my previous comment. Either we don't use the render lib for this and we do it outside checking all the types, or have a different component in the render lib for the preview of the message. But we shouldn't change the SourceMessage for this. @airyhq/codeowners-frontend
closes #1808