[#3130] Feature/endpoint for retrieving the current configuration #3177
Conversation
| configmapList, err := s.clientSet.CoreV1().ConfigMaps(s.namespace).List(r.Context(), v1.ListOptions{LabelSelector: "core.airy.co/component"}) | ||
| if err != nil { | ||
| log.Printf("Unable to list config maps. Error: %s\n", err) | ||
| w.WriteHeader(http.StatusInternalServerError) |
There was a problem hiding this comment.
Do you think it'd be useful to return the error in a json response payload like we do with other endpoints?
There was a problem hiding this comment.
When it comes to internal server errors like kubectl errors. they should not be forwarded to the client
|
|
||
| blob, err := json.Marshal(map[string]interface{}{"components": components}) | ||
| if err != nil { | ||
| log.Printf("Unable to marchal config Error: %s\n", err) |
There was a problem hiding this comment.
| log.Printf("Unable to marchal config Error: %s\n", err) | |
| log.Printf("Unable to marshal config Error: %s\n", err) |
| @@ -38,5 +39,8 @@ func Serve(clientSet *kubernetes.Clientset, namespace string) { | |||
| s := &Services{clientSet: clientSet, namespace: namespace} | |||
| r.Handle("/services", s) | |||
|
|
|||
| cg := &ClusterGet{clientSet: clientSet, namespace: namespace} | |||
| r.Handle("/cluster.get", cg).Methods("GET") | |||
There was a problem hiding this comment.
Like all our other endpoints this should be a POST
|
|
||
| var secretMatcher = regexp.MustCompile(`(?i)secret|key|token`) | ||
|
|
||
| func maskSecrets(data map[string]string) map[string]string { |
There was a problem hiding this comment.
Very good thinking! Long term I think the services need to add some metadata so that we know which fields to mask without hardcoding it. What do you think?
There was a problem hiding this comment.
Yes this is what we were talking yesterday. we can do this in a second iteration
|
The docs are going to made in #3130 |
juan-sebastian
deleted the
feature/3130-endpoint-for-retrieving-the-current-configuration
branch
closes #3130