Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3171] Admin api unhealthy on minikube #3219

Merged
merged 2 commits into from
May 30, 2022
Merged

[#3171] Admin api unhealthy on minikube #3219

merged 2 commits into from
May 30, 2022

Conversation

chrismatix
Copy link
Contributor

@chrismatix chrismatix commented May 26, 2022 •
edited
Loading

resolves #3171

This is caused by a longstanding minikube issue and fixing it by adding --cni=true to the startup options would apparently incur a ~30% performance cost.

@github-actions github-actions bot added the fix label May 26, 2022
ljupcovangelski
ljupcovangelski approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@ljupcovangelski ljupcovangelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. We probably need an issue to update our docs and introduce the term app as a building block of a component. A component can be comprised of multiple apps.

ljupcovangelski
ljupcovangelski reviewed May 27, 2022
View reviewed changes
infrastructure/helm-chart/charts/components/templates/api/admin/deployment.yaml
- name: KUBERNETES_APP
valueFrom:
fieldRef:
fieldPath: metadata.labels['app']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@chrismatix chrismatix merged commit f7233e9 into develop May 30, 2022
@chrismatix chrismatix deleted the fix/3171-admin-unhealthy-locally branch May 30, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljupcovangelski ljupcovangelski ljupcovangelski approved these changes

@juan-sebastian juan-sebastian Awaiting requested review from juan-sebastian

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Api-Admin unhealthy in local instance
2 participants
@chrismatix @ljupcovangelski