Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3101] Added contacts to Inbox #3233

Merged
merged 10 commits into from
Jun 1, 2022
Merged

Conversation

stayprodio
Copy link
Contributor

closes #3101

@stayprodio
Copy link
Contributor Author

sorting alphabetical of contacts gonna be fixed by backend

Copy link
Contributor

@AitorAlgorta AitorAlgorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments. Putting those numbers into variables is important for readability and understanding the code, but also in case we want to change from pages of 9 and loading 5 pages, to loading different numbers, we can change it easily.


export const listContacts = () => (dispatch: Dispatch<any>, state: () => StateModel) => {
const cursor = state().data.contacts.all.paginationData.nextCursor;
HttpClientInstance.listContacts({page_size: 54, cursor: cursor}).then((response: PaginatedResponse<Contact>) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have this number in a variable?

frontend/inbox/src/pages/Contacts/index.tsx Outdated Show resolved Hide resolved
frontend/inbox/src/pages/Contacts/index.tsx Outdated Show resolved Hide resolved
frontend/inbox/src/pages/Contacts/index.tsx Outdated Show resolved Hide resolved
AitorAlgorta
AitorAlgorta previously approved these changes Jun 1, 2022
Copy link
Contributor

@AitorAlgorta AitorAlgorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@stayprodio stayprodio merged commit 8fb95c0 into develop Jun 1, 2022
@stayprodio stayprodio deleted the feature/3101-add-contacts-inbox branch June 1, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Contacts" view + Contacts List (Inbox)
2 participants