-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3101] Added contacts to Inbox #3233
Conversation
sorting alphabetical of contacts gonna be fixed by backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments. Putting those numbers into variables is important for readability and understanding the code, but also in case we want to change from pages of 9 and loading 5 pages, to loading different numbers, we can change it easily.
frontend/control-center/src/pages/Connectors/ConnectedChannelsList/index.tsx
Outdated
Show resolved
Hide resolved
|
||
export const listContacts = () => (dispatch: Dispatch<any>, state: () => StateModel) => { | ||
const cursor = state().data.contacts.all.paginationData.nextCursor; | ||
HttpClientInstance.listContacts({page_size: 54, cursor: cursor}).then((response: PaginatedResponse<Contact>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have this number in a variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
closes #3101