Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202011 singularitycli #216

Merged
merged 10 commits into from
Dec 16, 2020
Merged

202011 singularitycli #216

merged 10 commits into from
Dec 16, 2020

Conversation

sakkabe
Copy link
Contributor

@sakkabe sakkabe commented Nov 25, 2020

No description provided.

sakkabe and others added 6 commits November 11, 2020 23:04
add singularity-cli usage
add using user docker image section
ja modify and add english
Copy link
Collaborator

@stakizawa stakizawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

日本語版への指摘事項は、英語版にも反映させてください。

ja/docs/09.md Outdated
Comment on lines 214 to 215
- pipにパスが通らない => pipへの環境変数PATHを設定
- WORKDIRにファイルがコピーされない => コピー先をWORKDIRの絶対パスに設定
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdocsで表示すると、リストになっていません。

ja/docs/09.md Outdated
(work) [username@es1 ~]$ pip3 install spython
```

以下の例では、NVIDIA社による[SSD300 v1.1モデル学習用コンテナイメージ](https://github.com/NVIDIA/DeepLearningExamples/tree/master/PyTorch/Detection/SSD)のDockerfileを編集し、Singularity Pythonを用いてSingularity recipeファイルに変換します。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以下のコマンド例では、どのファイルが出力ファイルなのかわかりにくいです。見やすさのため、上記の文章の末の方を「Singularity recipeファイル(ssd.def)」としましょう。

en/docs/09.md Outdated
### Build Singularity image from Dockerfile {#build-image-from-dockerfile}

On ABCI, you cannot build a Singularity image directly from Dockerfile.
If you have only Dockerfile, you have two way to build a Singularity image on ABCI.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two ways

en/docs/09.md Outdated

#### Via Docker Hub {#build-via-dockerhub}

Build a Docker container image from Dockerfile on a system having Docker execution environment, and upload to Docker Hub. You can use the Docker container image on ABCI.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「and upload to Docker Hub.」=>「and upload the image to Docker Hub.」

en/docs/09.md Outdated

Build a Docker container image from Dockerfile on a system having Docker execution environment, and upload to Docker Hub. You can use the Docker container image on ABCI.

Following example shows how to build [SSD300 v1.1 image](https://github.com/NVIDIA/DeepLearningExamples/tree/master/PyTorch/Detection/SSD) supported by NVIDIA from Dockerfile and to upload Docker Hub.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「supported」=>「developed」の方が良い。
「and to upload Docker Hub.」=>「and upload it to Docker Hub.」

en/docs/09.md Outdated

!!!warning
Conversion between Dockerfile and Singularity recipe Singularity Python is possible but not perfect.
If `singularity build` fails in the converted Singularity recipe file, please modify the recipe file manually.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If singularity build fails when the generated Singularity recipe file is used, modify the recipe file manually.

en/docs/09.md Outdated
Conversion between Dockerfile and Singularity recipe Singularity Python is possible but not perfect.
If `singularity build` fails in the converted Singularity recipe file, please modify the recipe file manually.

Example of installation of Singularity Python)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example procedure for installing Singularity Python)

en/docs/09.md Outdated
(work) [username@es1 ~]$ pip3 install spython
```

Following example shows how to modify Dockerfile of [SSD300 v1.1 image](https://github.com/NVIDIA/DeepLearningExamples/tree/master/PyTorch/Detection/SSD) supported by NVIDIA and convert it to Singularity recipe using Singularity Python.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「supported」=>「developed」

en/docs/09.md Outdated

Following example shows how to modify Dockerfile of [SSD300 v1.1 image](https://github.com/NVIDIA/DeepLearningExamples/tree/master/PyTorch/Detection/SSD) supported by NVIDIA and convert it to Singularity recipe using Singularity Python.

If you convert the original Dockerfile, the following two problems will occur at build time, so you need to modify the Dockerfile before conversion.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

分割&微修正。
If you convert the original Dockerfile as is, the following two problems will occur at build time.
To avoid the problems, this example modifies the Dockerfile before conversion.

en/docs/09.md Outdated
(work) [username@es1 SSD]$ spython recipe Dockerfile ssd.def
```

How to create a Singularity image, please refer [Create a Singularity image (build)](#create-a-singularity-image-build).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「How to create a Singularity image」=>「To create a Singularity image from the generated recipe file on ABCI」
「please refer」=>「please refer to」

@stakizawa
Copy link
Collaborator

確認しました。問題ないです。
メンテナンス明けに公開できるようマージしましょう。

@ogawa ogawa mentioned this pull request Dec 5, 2020
@ogawa ogawa changed the base branch from master to devel-202012 December 5, 2020 12:14
@ogawa ogawa mentioned this pull request Dec 5, 2020
@stakizawa
Copy link
Collaborator

DockerfileからのSingularity build時のDocker環境変数読み込みについて、ドキュメントを修正してください。

sakkabe and others added 2 commits December 10, 2020 12:09
modify recipe file
@stakizawa stakizawa added this to the release-202012 milestone Dec 15, 2020
@stakizawa stakizawa merged commit 1167889 into devel-202012 Dec 16, 2020
@ogawa ogawa linked an issue Dec 16, 2020 that may be closed by this pull request
@sakkabe sakkabe deleted the 202011-singularitycli branch March 25, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

既存PRのmerge (216)
2 participants