Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(platform): BYOC AWS GA #3

Merged
merged 3 commits into from
Mar 20, 2024
Merged

update(platform): BYOC AWS GA #3

merged 3 commits into from
Mar 20, 2024

Conversation

wojcik-dorota
Copy link
Contributor

@wojcik-dorota wojcik-dorota commented Jan 26, 2024 •
edited
Loading

@wojcik-dorota wojcik-dorota self-assigned this Jan 26, 2024
@wojcik-dorota wojcik-dorota changed the title [WiP] BYOC AWS GA updates platform: [WiP] BYOC AWS GA updates Jan 26, 2024
@wojcik-dorota wojcik-dorota changed the title platform: [WiP] BYOC AWS GA updates platform: BYOC AWS GA updates Jan 26, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 26, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 09a734f
Status: ✅  Deploy successful!
Preview URL: https://be52d3d5.aiven-docs.pages.dev
Branch Preview URL: https://dorota-platfrom-byoc-aws-ga.aiven-docs.pages.dev

View logs

@wojcik-dorota wojcik-dorota force-pushed the dorota-platfrom-byoc-aws-ga-updates branch 3 times, most recently from 3afa86d to 53e7d54 Compare January 26, 2024 14:07
@wojcik-dorota wojcik-dorota marked this pull request as ready for review January 26, 2024 14:10
@wojcik-dorota wojcik-dorota changed the title platform: BYOC AWS GA updates update(platform): BYOC AWS GA Jan 26, 2024
@wojcik-dorota wojcik-dorota mentioned this pull request Jan 28, 2024
Closed
@wojcik-dorota wojcik-dorota force-pushed the dorota-platfrom-byoc-aws-ga-updates branch 2 times, most recently from 65b5057 to b762e17 Compare January 29, 2024 13:53
@wojcik-dorota wojcik-dorota force-pushed the dorota-platfrom-byoc-aws-ga-updates branch from b762e17 to c07f381 Compare January 30, 2024 07:07
@wojcik-dorota wojcik-dorota added review/awaitingRelease All reviews are completed. review/SME An SME must review the PR. labels Jan 31, 2024
@wojcik-dorota wojcik-dorota force-pushed the dorota-platfrom-byoc-aws-ga-updates branch from c07f381 to 8911c9b Compare February 1, 2024 15:43
@wojcik-dorota wojcik-dorota requested review from SmuliS and removed request for akudiyar and tilman-aiven February 5, 2024 16:15
@wojcik-dorota wojcik-dorota force-pushed the dorota-platfrom-byoc-aws-ga-updates branch from 8911c9b to ca15429 Compare February 8, 2024 06:54
@jeremy-heller-aiven
Copy link

I just found a discrepancy in the Who is eligible for BYOC section. The $5000 minimum spend has been removed as a requirement, and BYOC is now only offered to customers with a commitment deal.

@wojcik-dorota
Copy link
Contributor Author

I just found a discrepancy in the Who is eligible for BYOC section. The $5000 minimum spend has been removed as a requirement, and BYOC is now only offered to customers with a commitment deal.

@jeremy-heller-aiven thanks for that! top important finding!

@jeremy-heller-aiven
Copy link

Otherwise, all looks great!

jeremy-heller-aiven
jeremy-heller-aiven previously requested changes Feb 14, 2024
View reviewed changes
Copy link

@jeremy-heller-aiven jeremy-heller-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update required to remove the $5000 send requirement, and to add the commitment deal pre-requisite for BYOC.

@wojcik-dorota wojcik-dorota force-pushed the dorota-platfrom-byoc-aws-ga-updates branch from ca15429 to 60ed4bb Compare February 14, 2024 15:40
jeremy-heller-aiven
jeremy-heller-aiven approved these changes Feb 19, 2024
View reviewed changes
Copy link

@jeremy-heller-aiven jeremy-heller-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wojcik-dorota wojcik-dorota added review/TW A TW must review the PR. Comes after review/SME. and removed review/SME An SME must review the PR. labels Feb 19, 2024
@wojcik-dorota wojcik-dorota force-pushed the dorota-platfrom-byoc-aws-ga-updates branch from 28d265f to cf110ab Compare February 21, 2024 14:03
ArthurFlag
ArthurFlag previously requested changes Feb 21, 2024
View reviewed changes
docs/platform/howto/byoc/create-custom-cloud.md Outdated Show resolved Hide resolved
docs/platform/howto/byoc/create-custom-cloud.md Outdated Show resolved Hide resolved
docs/platform/howto/byoc/create-custom-cloud.md Outdated Show resolved Hide resolved
docs/platform/howto/byoc/create-custom-cloud.md Outdated Show resolved Hide resolved
docs/platform/howto/byoc/create-custom-cloud.md Outdated Show resolved Hide resolved
docs/platform/howto/byoc/assign-project-custom-cloud.md Outdated Show resolved Hide resolved
docs/platform/howto/byoc/create-custom-cloud.md Outdated Show resolved Hide resolved
docs/platform/howto/byoc/create-custom-cloud.md Outdated Show resolved Hide resolved
docs/platform/howto/byoc/assign-project-custom-cloud.md Outdated Show resolved Hide resolved
@wojcik-dorota wojcik-dorota removed the review/TW A TW must review the PR. Comes after review/SME. label Feb 21, 2024
@wojcik-dorota wojcik-dorota force-pushed the dorota-platfrom-byoc-aws-ga-updates branch from dcc1ec6 to 901c393 Compare March 11, 2024 16:01
jeremy-heller-aiven
jeremy-heller-aiven previously requested changes Mar 12, 2024
View reviewed changes
Copy link

@jeremy-heller-aiven jeremy-heller-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few suggestions

docs/platform/howto/byoc/create-custom-cloud.md
When creating a service in the [Aiven Console](https://console.aiven.io/), at the
**Select service region** step, select **Custom clouds** from the available regions.

### Migrate existing services to the custom cloud
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would take this part out because we added this text throughout the document already: "Migrating existing services to your custom cloud is possible, depending on your specific service and networking configuration. Please reach out to the sales team to understand your specific migration scenario."

Copy link
Contributor Author

@wojcik-dorota wojcik-dorota Mar 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we still keep the section for the SEO purposes and making this migration capability visible to the users in the table of contents? I updated the sections accordingly saying what we want to say. Hope that's ok?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SEO is great! I hadn't thought of that. I'll review the draft

docs/platform/howto/byoc/create-custom-cloud.md Outdated Show resolved Hide resolved
docs/platform/howto/byoc/create-custom-cloud.md Show resolved Hide resolved
docs/platform/howto/byoc/assign-project-custom-cloud.md Outdated Show resolved Hide resolved
@wojcik-dorota wojcik-dorota force-pushed the dorota-platfrom-byoc-aws-ga-updates branch from 901c393 to 09a734f Compare March 12, 2024 12:18
jeremy-heller-aiven
jeremy-heller-aiven requested changes Mar 12, 2024
View reviewed changes
Copy link

@jeremy-heller-aiven jeremy-heller-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small change... Sales just informed me that at least the Priority Support Tier is required for BYOC

@jeremy-heller-aiven
Copy link

The priority support tier was already added, so all looks good!

@staceysalamon-aiven staceysalamon-aiven merged commit 7c0dc5c into main Mar 20, 2024
4 checks passed
@staceysalamon-aiven staceysalamon-aiven deleted the dorota-platfrom-byoc-aws-ga-updates branch March 20, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremy-heller-aiven jeremy-heller-aiven jeremy-heller-aiven approved these changes

@ArthurFlag ArthurFlag ArthurFlag approved these changes

@heikju heikju Awaiting requested review from heikju

@SmuliS SmuliS Awaiting requested review from SmuliS

Assignees

@wojcik-dorota wojcik-dorota

Labels
platform review/awaitingRelease All reviews are completed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wojcik-dorota @jeremy-heller-aiven @ArthurFlag @staceysalamon-aiven