Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: Governance overview and enabling content #342

Merged
merged 14 commits into from
Aug 1, 2024
Merged

add: Governance overview and enabling content #342

merged 14 commits into from
Aug 1, 2024

Conversation

harshini-rangaswamy
Copy link
Contributor

@harshini-rangaswamy harshini-rangaswamy commented Jul 22, 2024 •
edited
Loading

Describe your changes

  • Governance overview
  • Enabling governance for the organization

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@github-actions github-actions bot added service/kafka tech Relates to technical updates of the docs platform. labels Jul 22, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 22, 2024 •
edited
Loading

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3572ee1
Status: ✅  Deploy successful!
Preview URL: https://2c981c05.aiven-docs.pages.dev
Branch Preview URL: https://harshini-enable-governance.aiven-docs.pages.dev

View logs

@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review July 23, 2024 08:12
@harshini-rangaswamy harshini-rangaswamy requested a review from a team as a code owner July 23, 2024 08:12
@harshini-rangaswamy harshini-rangaswamy added the review/SME An SME must review the PR. label Jul 23, 2024
@harshini-rangaswamy harshini-rangaswamy self-assigned this Jul 23, 2024
@harshini-rangaswamy harshini-rangaswamy added the review/TW A TW must review the PR. Comes after review/SME. label Jul 24, 2024
aindriu-aiven
aindriu-aiven approved these changes Jul 25, 2024
View reviewed changes
Copy link

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshini-rangaswamy harshini-rangaswamy removed the review/SME An SME must review the PR. label Jul 25, 2024
wojcik-dorota
wojcik-dorota requested changes Jul 26, 2024
View reviewed changes
docs/products/kafka/concepts/governance-overview.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/governance-overview.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/governance-overview.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/governance-overview.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/governance-overview.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/enable-governance.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/enable-governance.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/enable-governance.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/enable-governance.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/governance.md Show resolved Hide resolved
wojcik-dorota
wojcik-dorota approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@wojcik-dorota wojcik-dorota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for possible improvements

@harshini-rangaswamy
Copy link
Contributor Author

Left some comments for possible improvements

Thanks! Addressed them, and the missing icon is a known issue. That will be resolved once the storybook is updated with new DS components.

@harshini-rangaswamy harshini-rangaswamy added review/awaitingRelease All reviews are completed. and removed review/TW A TW must review the PR. Comes after review/SME. labels Aug 1, 2024
@harshini-rangaswamy harshini-rangaswamy merged commit 9288ae5 into main Aug 1, 2024
4 checks passed
@harshini-rangaswamy harshini-rangaswamy deleted the harshini-enable-governance branch August 1, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haach haach haach left review comments

@ArthurFlag ArthurFlag ArthurFlag left review comments

@aindriu-aiven aindriu-aiven aindriu-aiven approved these changes

@wojcik-dorota wojcik-dorota wojcik-dorota approved these changes

@programmiri programmiri Awaiting requested review from programmiri

@muralibasani muralibasani Awaiting requested review from muralibasani

Assignees

@harshini-rangaswamy harshini-rangaswamy

Labels
review/awaitingRelease All reviews are completed. service/kafka tech Relates to technical updates of the docs platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@harshini-rangaswamy @muralibasani @ArthurFlag @haach @wojcik-dorota @aindriu-aiven