Prod 1785 enable adding any embedding in ai r not just embedding model #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Muhammad-Elmallah
commented
May 7, 2025
Muhammad-Elmallah
commented
- Removed private models from SDK
- Enabled calling aiR with any embedding model ID
- Add validation for the model (validate_embedding_model)
Muhammad-Elmallah
requested review from
basitanees,
thiago-aixplain and
lucas-aixplain
thiago-aixplain
suggested changes
May 20, 2025
| from urllib.parse import urljoin | ||
|
|
||
| def validate_embedding_model(model_id) -> bool: | ||
| resp = None |
There was a problem hiding this comment.
Use ModelFactory instead. Please also use pre-commit to fix the indentation
aixplain/enums/embedding_model.py
Outdated
| @@ -21,13 +21,13 @@ | |||
|
|
|||
|
|
|||
| class EmbeddingModel(str, Enum): | |||
| SNOWFLAKE_ARCTIC_EMBED_M_LONG = "6658d40729985c2cf72f42ec" | |||
| # SNOWFLAKE_ARCTIC_EMBED_M_LONG = "6658d40729985c2cf72f42ec" | |||
Muhammad-Elmallah
force-pushed
the
PROD-1785-enable-adding-any-embedding-in-ai-r-not-just-embedding-model
branch
from
2e9ed57 to
8c95f35
Compare
thiago-aixplain
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.