Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate test failure with new MOOSE #25

Closed
lindsayad opened this issue May 26, 2023 · 7 comments · Fixed by #26
Closed

Investigate test failure with new MOOSE #25

lindsayad opened this issue May 26, 2023 · 7 comments · Fixed by #26
Assignees
@ajacquey @lindsayad

Comments

@lindsayad
Copy link
Collaborator

lindsayad commented May 26, 2023 •
edited
Loading

As outlined in idaholab/moose#24499 the THM_doublet test is failing with new MOOSE.
@ajacquey ajacquey self-assigned this May 26, 2023
@lindsayad
Copy link
Collaborator Author

@ajacquey I was planning to do this, but will hold off if you're investigating!

@ajacquey
Copy link
Owner

After updating MOOSE, I got some compiling errors in GolemKernelTimeT.C related to old synthax in computeResidual and computeJacobian

@lindsayad
Copy link
Collaborator Author

As stated in idaholab/moose#24499 I believe this may be due to idaholab/moose#24018

@ajacquey
Copy link
Owner

Yes, I think I have found a fix.
I'm running the input file in question doublet_THM.i now to test if the issue remains

@lindsayad
Copy link
Collaborator Author

Yea I can fix that as well. Why don't you go ahead and assign me to this?

@lindsayad
Copy link
Collaborator Author

Ah ok. You were able to update the residualBlock and jacobianBlock failures?

@ajacquey
Copy link
Owner

I think so. I will open a PR so you can have a look to be sure.
Thanks

ajacquey added a commit that referenced this issue May 26, 2023
@ajacquey
Fixed compiling error with new MOOSE #25
d696e5e
@ajacquey ajacquey linked a pull request May 26, 2023 that will close this issue
Fixed compiling error with new MOOSE #25 #26
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajacquey ajacquey

@lindsayad lindsayad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed compiling error with new MOOSE #25 ajacquey/golem
2 participants
@ajacquey @lindsayad