By default always do a final prepare_for_use #24018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof @ CI |
|
Job Documentation on 9b26602 wanted to post the following: View the site here This comment will be updated on new commits. |
|
The outright errors are fixed by the most recent commit. The exodiffs illustrate the problem with not making sure your mesh is prepared 😆 |
Yes this was the what the oof was about 😬 |
lindsayad
force-pushed
the
paolo-problem
branch
from
e3a7029
to
ca21d98
Compare
lindsayad
force-pushed
the
paolo-problem
branch
3 times, most recently
from
8059c78
to
c0defb4
Compare
lindsayad
added a commit
to lindsayad/libmesh
that referenced
this pull request
Apr 11, 2023
The blksize was wrong if `partition_range` was called (again) after the mesh had been distributed. Now I'm getting the same partitioning even if I call `prepare_for_use` twice This is relevant to work on idaholab/moose#24018
|
big simplification incoming |
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
Apr 11, 2023
lindsayad
force-pushed
the
paolo-problem
branch
from
38429d5
to
71252ce
Compare
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
Apr 11, 2023
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
Apr 11, 2023
lindsayad
force-pushed
the
paolo-problem
branch
from
71252ce
to
ebc3df0
Compare
|
There may be one test failure until libMesh/libmesh#3514 makes it into MOOSE |
lindsayad
changed the title
3 tasks
|
Will be updating now that we have |
lindsayad
force-pushed
the
paolo-problem
branch
from
7a9e5cc
to
d770140
Compare
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
Apr 20, 2023
|
Job Framework 2 on 9b26602 : invalidated by @lindsayad |
|
Job Internal app tests on 9b26602 : invalidated by @lindsayad |
|
All jobs on 9b26602 : invalidated by @lindsayad |
|
ready for re-review |
|
Thanks for the review @GiudGiud ! |
|
In case you didn't see it: https://civet.inl.gov/event/122927/ |
|
Taking a look |
|
Test seems to rely on the mesh not being prepared for the sidesetbetweensubdomaingenerators (either of them?) EDIT: actually, setting as unprepared, at any point, creates the exodiff. |
GiudGiud
added a commit
to GiudGiud/moose
that referenced
this pull request
May 8, 2023
addresses test failure from idaholab#24018 which resolved idaholab#14329
|
It looks like is failing quite often with |
|
In what way? |
|
Crashes. Let me see if I can duplicate it easily on rod. |
Elley-Folks
pushed a commit
to Elley-Folks/Elley-moose
that referenced
this pull request
May 10, 2023
addresses test failure from idaholab#24018 which resolved idaholab#14329
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
May 15, 2023
Defaulting got me in trouble again in SAM after idaholab#24018
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
May 15, 2023
Defaulting got me in trouble again in SAM after idaholab#24018
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
May 15, 2023
Defaulting got me in trouble again in SAM after idaholab#24018
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
May 31, 2023
In idaholab#24018 we checked to see whether the reference mesh base object was prepared in `MooseMesh::prepare`, and if so then we would later also prepare the displaced mesh. The issue with this is that even Metis may yield different partitions for identical meshes and this plays havoc when we want to sync vectors between undisplaced and displaced meshes. Back when we had this problem in the past we proposed issue idaholab#12799 as a solution but ended up going with idaholab#12889 which has the same spirit as this new fix: *ensure* the displaced mesh is an exact copy of the reference mesh. Now of course I am getting paranoid about what can happen when we have adaptivity... Thank you to discussion idaholab#24499 for illustrating that we had this issue crop up again
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
May 31, 2023
In idaholab#24018 we checked to see whether the reference mesh base object was prepared in `MooseMesh::prepare`, and if so then we would later also prepare the displaced mesh. The issue with this is that even Metis may yield different partitions for identical meshes and this plays havoc when we want to sync vectors between undisplaced and displaced meshes. Back when we had this problem in the past we proposed issue idaholab#12799 as a solution but ended up going with idaholab#12889 which has the same spirit as this new fix: *ensure* the displaced mesh is an exact copy of the reference mesh. Now of course I am getting paranoid about what can happen when we have adaptivity... Thank you to discussion idaholab#24499 for illustrating that we had this issue crop up again
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
Jun 21, 2023
tanoret
pushed a commit
to tanoret/moose
that referenced
this pull request
Jul 10, 2023
In idaholab#24018 we checked to see whether the reference mesh base object was prepared in `MooseMesh::prepare`, and if so then we would later also prepare the displaced mesh. The issue with this is that even Metis may yield different partitions for identical meshes and this plays havoc when we want to sync vectors between undisplaced and displaced meshes. Back when we had this problem in the past we proposed issue idaholab#12799 as a solution but ended up going with idaholab#12889 which has the same spirit as this new fix: *ensure* the displaced mesh is an exact copy of the reference mesh. Now of course I am getting paranoid about what can happen when we have adaptivity... Thank you to discussion idaholab#24499 for illustrating that we had this issue crop up again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #14329