Hide Ace content from assistive technologies to improve a11y #5160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5160 +/- ##
==========================================
+ Coverage 86.92% 86.93% +0.01%
==========================================
Files 561 561
Lines 44912 44935 +23
Branches 6907 6909 +2
==========================================
+ Hits 39039 39066 +27
+ Misses 5873 5869 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
src/keyboard/textinput.js
Outdated
Comment on lines
68
to
69
| if(host.session && host.renderer.enableKeyboardAccessibility) | ||
| { |
There was a problem hiding this comment.
Doesn't look in line with the code style
There was a problem hiding this comment.
ah whoops, you're right. Fixed in new commit
akoreman
changed the title
ibabanov-aws
approved these changes
May 10, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2164
Some screen reader/browser configurations read the entire visible part of the document when entering Ace. This aims to improve the screen reader experience by hiding the
ace_contentdiv from assistive technologies when a11y mode is enabled.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.