This repository has been archived by the owner on Oct 5, 2018. It is now read-only.
Initial checkin for supporting MaxVersion in SemVerStrategyState #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t step is to define some version strategies that make use of it
|
Overall, this code looks good, but I'd like to play out the idea of reusing NearestVersionLocator some more. I'll throw together my own PR for this and we can see what the best next steps will be. |
|
Just created #118 for my alternate impl. Still need to push up the tests for it. However, I don't think that approach is going to work very well. Without understanding what the branches are being used for, it's hard (maybe impossible) to know whether parallel development should override the nearest. |
|
any movements on this? i think this might solve one of my issue: |
|
See my comment on #202 . |
|
I still want to address this, but given how long this PR's been open, I'm going to close. The original issue is still open. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step is to define some version strategies that make use of it