Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of relative paths and running from non-Git-root #584

Merged
merged 9 commits into from
Apr 16, 2024
Merged

Fix handling of relative paths and running from non-Git-root #584

merged 9 commits into from
Apr 16, 2024

Commits on Apr 16, 2024

  1. Rename root to common_root in main for clarity

    @akaihola
    akaihola committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    76020f8 View commit details
    Browse the repository at this point in the history

  2. Add clarifying comment in main()

    @akaihola
    akaihola committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    dfa0105 View commit details
    Browse the repository at this point in the history

  3. Fix path handling in _git_exists_in_revision 

    Now Git calls work correctly even if the common root directory in which
to run Git doesn't exist anymore.
    @akaihola
    akaihola committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4e67669 View commit details
    Browse the repository at this point in the history

  4. Clarify get_missing_at_revision docstring

    @akaihola
    akaihola committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4daedb2 View commit details
    Browse the repository at this point in the history

  5. cwd= -> repo_root= in _git_diff_name_only()

    @akaihola
    akaihola committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7543f05 View commit details
    Browse the repository at this point in the history

  6. _git_ls_files_others docstring clarification

    @akaihola
    akaihola committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    cc19c6e View commit details
    Browse the repository at this point in the history

  7. Fix _git_ls_files_others() 

    - rename `cwd=` to `repo_root=` for clarity
- transform paths: relative to cwd -> relative to `repo_root`
    @akaihola
    akaihola committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1a87f5c View commit details
    Browse the repository at this point in the history

  8. Test cases for running from non-Git-root 

    Add such test cases to tests for
- `_git_exists_in_revision()`
- `get_missing_at_revision()`
    @akaihola
    akaihola committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b0a2674 View commit details
    Browse the repository at this point in the history

  9. Update the change log

    @akaihola
    akaihola committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    8e8deb2 View commit details
    Browse the repository at this point in the history