Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create API #15

Merged
merged 11 commits into from
May 24, 2021
Merged

Add create API #15

merged 11 commits into from
May 24, 2021

Conversation

akalin
Copy link
Owner

@akalin akalin commented Mar 7, 2021

Add create API for #6.

@akalin akalin force-pushed the create-api branch 3 times, most recently from 8f9a7d6 to 740c56d Compare March 7, 2021 04:59
@akalin
Copy link
Owner Author

akalin commented Mar 7, 2021

@brenthuisman what do you think of this API for creating a par2 file? (take a look at main.go) would you be able to use it?

@brenthuisman
Copy link
Contributor

Looks good! The EncoderDelegate seems optional (it'll default when set to nil). Is there any use-case where a library consumer might want/need to set this?

@akalin
Copy link
Owner Author

akalin commented Mar 8, 2021

The default delegate logs to stdout/stderr, which libraries shouldn't do in general (IMO), unless there's some way to turn it off.

Is the default logging behavior desired for your use case? If not, I might just make the default not log at all.

@brenthuisman
Copy link
Contributor

By default I intercept stdout and stderr and route to /dev/null.

@akalin
Copy link
Owner Author

akalin commented Mar 8, 2021

Ah cool, I'll set it to not log by default, then.

@akalin akalin force-pushed the create-api branch 2 times, most recently from ebf5b12 to ba4981f Compare April 4, 2021 17:14
@akalin akalin changed the title Create api Add create API May 16, 2021
@akalin akalin merged commit d28bb58 into main May 24, 2021
@akalin akalin deleted the create-api branch May 24, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants