Add verify API #16
Merged
Add verify API #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akalin
force-pushed
the
verify-api
branch
12 times, most recently
from
6fdb624
to
ad48b87
Compare
akalin
force-pushed
the
create-api
branch
2 times, most recently
from
7e7014b
to
6f9c2db
Compare
akalin
force-pushed
the
verify-api
branch
2 times, most recently
from
645b63c
to
7a97e4a
Compare
|
@brenthuisman finally got back to coding on this. what do you think of this API for verifying a par2 file? (take a look at main.go) would you be able to use it? |
Also add DoNothingDecoderInterface and checkExtension helper function. Feature-Start: verify-api
Rename existing verify tests.
Also add DoNothingDecoderInterface and checkExtension helper function.
Rename existing verify tests.
Also change processVerifyOrRepairError to processRepairError, and make it print to stdout instead of stderr.
Add VerifyAllData option, and create a new FileCounts type that is in VerifyResult.
Create a new ShardCounts type that is in VerifyResult. Remove now-unneeded par2.Decoder.Verify and rsec16.Coder.CanReconstructData functions. Feature-End: verify-api
|
Merging this, but I can address any comments in a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add verify API.